chore: validate env expo cp-7.63.0 by weitingsun · Pull Request #25415 · MetaMask/metamask-mobile

weitingsun · 2026-01-29T21:12:53Z

Description

Move creating .env from push-eas-update.yml to build.sh
Have eas push platform as an input so we can choose to push to all, ios or android

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes the OTA update GitHub Actions workflow and scripts/build.sh publish path, including new platform selection and altered .env generation; mistakes could break release/update automation or omit required env values.

Overview
Adds a platform input to the push-eas-update workflow and passes it through as OTA_PUSH_PLATFORM, allowing OTA updates to target ios, android, or all.

Updates scripts/build.sh’s expo-update flow to generate .env (and mirror vars into GITHUB_ENV) from a fixed allowlist, then publish EAS updates sequentially per platform with explicit per-platform failure reporting/propagation. Also removes the workflow’s EXPO_NO_LAVAMOAT override and hardens Sentry auth token injection by switching sed to a safer delimiter.

^{Written by Cursor Bugbot for commit faa3f6b. This will update automatically on new commits. Configure here.}

github-actions · 2026-01-29T21:13:03Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

.github/workflows/push-eas-update.yml

cursor · 2026-01-29T21:18:27Z

.github/workflows/push-eas-update.yml

+            value="${!var}"
+            if [ -n "$value" ]; then
+              echo "${var}=${value}" >> .env
+              echo "${var}=${value}" >> "$GITHUB_ENV"


Environment values lack escaping for special characters

Low Severity

The new .env creation writes values without escaping or quoting: echo "${var}=${value}". The removed createEnvFile() function properly escaped backslashes, double quotes, and dollar signs, then wrapped values in quotes. If any secret values contain special characters (like $, ", \, or spaces), they could cause parsing issues when Expo reads the .env file or trigger unintended shell expansion.

.github/workflows/push-eas-update.yml

scripts/build.sh

codecov-commenter · 2026-01-29T23:43:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.27%. Comparing base (de82fcb) to head (4d92ae7).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #25415      +/-   ##
==========================================
- Coverage   80.55%   80.27%   -0.29%     
==========================================
  Files        4257     4263       +6     
  Lines      109159   109959     +800     
  Branches    23213    23417     +204     
==========================================
+ Hits        87937    88267     +330     
- Misses      15089    15506     +417     
- Partials     6133     6186      +53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

scripts/build.sh

github-actions · 2026-01-30T19:16:25Z

🔍 Smart E2E Test Selection

Selected E2E tags: None (no tests recommended)
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 92%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are purely CI/build infrastructure modifications:

.github/workflows/push-eas-update.yml: Added a new platform input parameter to allow selecting which platform (ios, android, or all) to update via EAS. Also removed the EXPO_NO_LAVAMOAT environment variable.
scripts/build.sh:
- Refactored createEnvFile() function with simplified escaping logic
- Modified buildExpoUpdate() to run iOS and Android updates sequentially (instead of simultaneously) to avoid LavaMoat lockdown serializer conflicts
- Added platform-specific logic based on OTA_PUSH_PLATFORM environment variable
- Fixed checkAuthToken() to use | as sed delimiter to handle special characters in auth tokens

These changes:

Do NOT modify any app source code (React Native components, controllers, business logic)
Do NOT affect E2E test infrastructure (no changes to e2e/ directory, test pages, fixtures, or utilities)
Are purely build/deployment workflow improvements for EAS OTA updates
Do NOT change how the app behaves at runtime

The validation for these changes would be running the actual EAS update workflow, not E2E tests. No E2E test tags are needed.

Performance Test Selection:
These changes are purely CI/build infrastructure modifications (GitHub workflow and build script). They do not affect any runtime app code, UI components, data loading, or app initialization. The changes are for EAS OTA update deployment process and have no impact on app performance metrics like rendering, loading times, or responsiveness.

View GitHub Actions results

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

scripts/build.sh

sonarqubecloud · 2026-01-30T19:38:46Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sethkfman

LGTM

.github/workflows/push-eas-update.yml

weitingsun added 3 commits January 29, 2026 10:21

chore: fix ota env exporting

0cd1525

move create .env back to push-eas-update.yml

7d4dd4d

Merge branch 'main' into chore/validate-env-expo

7d24363

weitingsun requested review from a team as code owners January 29, 2026 21:12

metamaskbot added the team-mobile-platform Mobile Platform team label Jan 29, 2026

github-actions bot added the size-M label Jan 29, 2026

cursor bot reviewed Jan 29, 2026

View reviewed changes

add env variables with empty values

1665c61

cursor bot reviewed Jan 29, 2026

View reviewed changes

.github/workflows/push-eas-update.yml Outdated Show resolved Hide resolved

print off first 3 characters of the env val

2c73880

weitingsun had a problem deploying to build-production January 29, 2026 22:07 — with GitHub Actions Failure

weitingsun had a problem deploying to build-production January 29, 2026 22:19 — with GitHub Actions Failure

weitingsun temporarily deployed to build-production January 29, 2026 22:32 — with GitHub Actions Inactive

move .env creation back to build.sh

4d92ae7

cursor bot reviewed Jan 29, 2026

View reviewed changes

scripts/build.sh Outdated Show resolved Hide resolved

scripts/build.sh Outdated Show resolved Hide resolved

weitingsun added 2 commits January 29, 2026 16:30

fix spacing

3d4e4ac

add .env back to push-eas-update.yml

895e26c

weitingsun had a problem deploying to build-production January 30, 2026 04:24 — with GitHub Actions Failure

weitingsun had a problem deploying to build-production January 30, 2026 15:40 — with GitHub Actions Failure

weitingsun had a problem deploying to build-production January 30, 2026 15:47 — with GitHub Actions Failure

fix parsing error

39ad433

weitingsun had a problem deploying to build-production January 30, 2026 16:14 — with GitHub Actions Failure

weitingsun had a problem deploying to build-production January 30, 2026 16:33 — with GitHub Actions Failure

weitingsun had a problem deploying to build-production January 30, 2026 16:45 — with GitHub Actions Failure

run builds sequentially

d29cc49

weitingsun temporarily deployed to build-production January 30, 2026 17:58 — with GitHub Actions Inactive

add platform as an input to push ota update

41826f4

cursor bot reviewed Jan 30, 2026

View reviewed changes

scripts/build.sh Show resolved Hide resolved

scripts/build.sh Show resolved Hide resolved

weitingsun added 2 commits January 30, 2026 11:05

exit if expo token is not set

c8746b7

fix platform variable bug

faa3f6b

cursor bot reviewed Jan 30, 2026

View reviewed changes

scripts/build.sh Show resolved Hide resolved

weitingsun temporarily deployed to build-production January 30, 2026 19:36 — with GitHub Actions Inactive

sethkfman approved these changes Jan 30, 2026

View reviewed changes

sethkfman reviewed Jan 30, 2026

View reviewed changes

.github/workflows/push-eas-update.yml Show resolved Hide resolved

weitingsun changed the title ~~Chore/validate env expo~~ chore: validate env expo Jan 30, 2026

weitingsun temporarily deployed to build-production January 30, 2026 20:32 — with GitHub Actions Inactive

weitingsun temporarily deployed to build-production January 30, 2026 20:33 — with GitHub Actions Inactive

weitingsun changed the title ~~chore: validate env expo~~ chore: validate env expo cp-7.63.0 Jan 30, 2026

weitingsun added this pull request to the merge queue Jan 30, 2026

Merged via the queue into main with commit 7e6bee4 Jan 30, 2026
122 of 126 checks passed

weitingsun deleted the chore/validate-env-expo branch January 30, 2026 23:24

github-actions bot locked and limited conversation to collaborators Jan 30, 2026

metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: validate env expo cp-7.63.0#25415

chore: validate env expo cp-7.63.0#25415
weitingsun merged 13 commits intomainfrom
chore/validate-env-expo

weitingsun commented Jan 29, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

Uh oh!

cursor bot Jan 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Jan 29, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 30, 2026

Uh oh!

sethkfman left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

weitingsun commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

Uh oh!

cursor bot Jan 29, 2026

Choose a reason for hiding this comment

Environment values lack escaping for special characters

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Jan 29, 2026

Codecov Report

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 30, 2026

🔍 Smart E2E Test Selection

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 30, 2026

Quality Gate passed

Uh oh!

sethkfman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

weitingsun commented Jan 29, 2026 •

edited

Loading