Skip to content

test: skip Chain Permission System E2E tests to reduce CI failures#25413

Merged
chrisleewilcox merged 1 commit intomainfrom
MUL-1431-mobile-skip-test
Jan 29, 2026
Merged

test: skip Chain Permission System E2E tests to reduce CI failures#25413
chrisleewilcox merged 1 commit intomainfrom
MUL-1431-mobile-skip-test

Conversation

@chrisleewilcox
Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox commented Jan 29, 2026 •
edited
Loading

Description

Changelog

It seems like app is restarting and causing test e2e/specs/multichain/permissions/chains/permission-system-dapp-chain-switch-grant.spec.js to fail after the test edits network permissions when trying to connect to test dapp.

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1431

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: this only disables an E2E spec via describe.skip, affecting test coverage/CI signal but not runtime app behavior.

Overview
Disables the Chain Permission System E2E suite by changing describe(...) to describe.skip(...) in permission-system-dapp-chain-switch-grant.spec.js, preventing the flaky chain-switch permission test from running in CI.

Written by Cursor Bugbot for commit baa93a8. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 29, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 29, 2026
@chrisleewilcox chrisleewilcox added No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Jan 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 29, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a simple test maintenance modification that adds .skip to a test suite's describe block in permission-system-dapp-chain-switch-grant.spec.js. This change:

  1. Only modifies a test file - No application code is changed
  2. Simply skips a test - The describe.skip() pattern is a standard Jest/Detox way to temporarily disable tests
  3. No functional impact - The app behavior is completely unchanged
  4. No test infrastructure changes - The test framework, fixtures, and utilities remain intact

Since this is purely a test management change (disabling a test), there's no need to run E2E tests to validate it. The test suite will continue to function normally - this particular test will simply be skipped during execution. Running E2E tests would not provide any additional validation for this type of change.

Performance Test Selection:
No application code is changed - this is purely a test file modification that skips a test. There is no impact on app performance since no runtime code is affected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 29, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chrisleewilcox chrisleewilcox added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit 34d62b1 Jan 29, 2026
136 of 139 checks passed
@chrisleewilcox chrisleewilcox deleted the MUL-1431-mobile-skip-test branch January 29, 2026 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sleepytanya sleepytanya sleepytanya approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-XS team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrisleewilcox @sleepytanya @metamaskbot