refactor(perps): use params in the controller and remove unused route#25412
refactor(perps): use params in the controller and remove unused route#25412michalconsensys merged 2 commits intomainfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
All changes are contained within the
No other features are affected by these changes. Performance Test Selection: |
|



Description
Refactor perps controller and remove unused route
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
No visible change
After
No visible change
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes the public
PerpsController.depositWithConfirmation/hook call signatures and the deposit+order transaction path toggle, which could break existing callers if any weren’t updated.Overview
Refactors perps deposit entrypoints by changing
PerpsController.depositWithConfirmationfrom positional args to a singleDepositWithConfirmationParamsobject (amount,placeOrder), and updatesdepositWithOrder/usePerpsTradingaccordingly.Cleans up navigation by removing the unused
Routes.PERPS.ORDERconstant and its screen registration from the perps route stack. Tests are updated to match the new deposit API shape.Written by Cursor Bugbot for commit 8ac4035. This will update automatically on new commits. Configure here.