Skip to content

chore: simplify local e2e testing setup#25402

Merged
juanmigdr merged 1 commit intomainfrom
chore/simplify-e2e-testing
Jan 30, 2026
Merged

chore: simplify local e2e testing setup#25402
juanmigdr merged 1 commit intomainfrom
chore/simplify-e2e-testing

Conversation

@juanmigdr
Copy link
Copy Markdown
Member

@juanmigdr juanmigdr commented Jan 29, 2026

Description

After trying to debug an e2e test that was failing on the CI, I attempted to set up my local environment to run these same e2e tests.

After a lot of trial and error, I managed to get them running, I have updated the Docs that explain how to get started and improved the install-ios-runway-app script so that it can be reused for this scenario which simplifies the tester's life and prevents them from having to download the build manually from runway

Changelog

CHANGELOG entry: simplify local e2e testing setup

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2569

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Changes are limited to developer documentation and a local iOS Runway install helper script; risk is mainly around breaking existing local workflows due to the new build/ artifact location and fixed MetaMask.app naming.

Overview
Simplifies local E2E setup docs by restructuring the flow into App Build (Expo prebuild download vs local build) and Run the E2E Tests (explicit two-terminal Metro/test execution steps), with clearer commands for running all tests, a folder, a file, or by tag.

Updates install-ios-runway-app.sh to store Runway artifacts in build/, always extract/expect MetaMask.app, and adds --skipInstall to support download-only runs without requiring a booted simulator.

Written by Cursor Bugbot for commit 3fcfa65. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes consist of:

  1. docs/readme/e2e-testing.md - Pure documentation changes reorganizing and improving the E2E testing setup guide. This includes better formatting, clearer instructions for Expo prebuilds vs local builds, and improved terminal session guidance. Documentation changes have zero impact on app functionality.

  2. scripts/install-ios-runway-app.sh - Developer tooling script changes:

    • Changed download directory from runway-artifacts to build
    • Added --skipInstall flag for download-only mode
    • Standardized app naming to always use "MetaMask.app"

This script is used for local development setup to download iOS builds from Runway. It does not affect:

  • The actual app code or functionality
  • E2E test specs, pages, or fixtures
  • CI/CD workflows or test execution
  • Any user-facing features

Both changes are purely developer experience improvements with no runtime impact on the MetaMask Mobile app. No E2E tests are needed to validate these changes.

Performance Test Selection:
These changes are documentation and developer tooling script updates only. They do not affect any app code, UI components, data loading, state management, or any runtime behavior. No performance impact is possible from these changes.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@juanmigdr juanmigdr changed the title chore: simplify local e2e testing chore: simplify local e2e testing setup Jan 30, 2026
@juanmigdr juanmigdr enabled auto-merge January 30, 2026 09:48
@juanmigdr juanmigdr added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit a9c05f5 Jan 30, 2026
83 of 88 checks passed
@juanmigdr juanmigdr deleted the chore/simplify-e2e-testing branch January 30, 2026 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants