Skip to content

feat: update E2E test configurations and clean up unused tags#25380

Merged
cmd-ob merged 5 commits intomainfrom
MMQA-1297-clean-up-tags
Jan 29, 2026
Merged

feat: update E2E test configurations and clean up unused tags#25380
cmd-ob merged 5 commits intomainfrom
MMQA-1297-clean-up-tags

Conversation

@cmd-ob
Copy link
Copy Markdown
Contributor

@cmd-ob cmd-ob commented Jan 29, 2026

Description

  • Remove 8 unused "Reserved" smoke tags that had no active tests
  • Remove the EXCLUDED_TAGS exclusion list from the Smart E2E selector
  • Add missing SmokeMultiChainAPI workflow jobs to Android and iOS smoke test workflows

Fixed SmokeMultiChainAPI Tests

  • Fixed MultichainTestDApp.ts to call getDappUrl() at runtime instead of import time
  • The previous code called getDappPort(0) at module load, before the dapp server was started
  • This was causing "Port not allocated for dapp-server-0" errors in CI

Details

Removed Unused Tags

The following smoke tags were defined but had zero active tests, causing the Smart E2E selector to potentially select tags that would run no tests:

Tag Reason
SmokeCore Reserved - never implemented
SmokeWalletUX Reserved - uses SmokeNetworkAbstractions
SmokeAssets Reserved - uses SmokeNetworkAbstractions
SmokeSwaps Reserved - covered by SmokeTrade
SmokeStake Reserved - covered by SmokeTrade
SmokeNotifications Reserved - uses SmokeNetworkAbstractions
SmokeMultiChainPermissions Reserved - split across other tags
SmokeAnalytics Reserved - distributed across feature tags

Removed EXCLUDED_TAGS

The EXCLUDED_TAGS array in handlers.ts is no longer needed since the unused tags have been removed from the source of truth (tags.js).

Added Missing Workflow Job

SmokeMultiChainAPI has 4 active test files but was missing from both workflow files:

  • wallet-createSession.spec.ts
  • wallet-getSession.spec.ts
  • wallet-revokeSession.spec.ts
  • wallet-sessionChanged.spec.ts

Files Changed

  • e2e/tags.js - Removed 8 unused tags and their exports
  • tests/tools/e2e-ai-analyzer/modes/select-tags/handlers.ts - Removed EXCLUDED_TAGS
  • .github/workflows/run-e2e-smoke-tests-android.yml - Added SmokeMultiChainAPI job
  • .github/workflows/run-e2e-smoke-tests-ios.yml - Added SmokeMultiChainAPI job

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it changes Smart E2E tag selection and adds new smoke workflow jobs, which can alter CI coverage/runtime and potentially surface new flaky tests.

Overview
Adds SmokeMultiChainAPI execution to both Android and iOS smoke workflows (including it in the final report dependencies) so those tests can be selected and run in CI.

Cleans up the Smart E2E tag source-of-truth by removing unused “reserved” smoke tags from e2e/tags.js and simplifying SELECT_TAGS_CONFIG generation to no longer filter via an EXCLUDED_TAGS list.

Fixes multichain dapp navigation in MultichainTestDApp.ts by resolving the local dapp URL at runtime via getDappUrl(0) (avoiding early port allocation failures).

Written by Cursor Bugbot for commit 2a98788. This will update automatically on new commits. Configure here.

@cmd-ob cmd-ob requested a review from a team as a code owner January 29, 2026 13:01
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cmd-ob cmd-ob added the skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run label Jan 29, 2026
@metamaskbot metamaskbot added the team-qa QA team label Jan 29, 2026
@cmd-ob cmd-ob added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Jan 29, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@cmd-ob cmd-ob requested a review from a team as a code owner January 29, 2026 13:40
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@cmd-ob cmd-ob enabled auto-merge January 29, 2026 20:14
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@cmd-ob cmd-ob added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit d2efea2 Jan 29, 2026
99 checks passed
@cmd-ob cmd-ob deleted the MMQA-1297-clean-up-tags branch January 29, 2026 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-M skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants