feat: update E2E test configurations and clean up unused tags#25380
Merged
feat: update E2E test configurations and clean up unused tags#25380
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
hjetpoluru
approved these changes
Jan 29, 2026
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
EXCLUDED_TAGSexclusion list from the Smart E2E selectorSmokeMultiChainAPIworkflow jobs to Android and iOS smoke test workflowsFixed SmokeMultiChainAPI Tests
MultichainTestDApp.tsto callgetDappUrl()at runtime instead of import timegetDappPort(0)at module load, before the dapp server was startedDetails
Removed Unused Tags
The following smoke tags were defined but had zero active tests, causing the Smart E2E selector to potentially select tags that would run no tests:
SmokeCoreSmokeWalletUXSmokeAssetsSmokeSwapsSmokeStakeSmokeNotificationsSmokeMultiChainPermissionsSmokeAnalyticsRemoved EXCLUDED_TAGS
The
EXCLUDED_TAGSarray inhandlers.tsis no longer needed since the unused tags have been removed from the source of truth (tags.js).Added Missing Workflow Job
SmokeMultiChainAPIhas 4 active test files but was missing from both workflow files:wallet-createSession.spec.tswallet-getSession.spec.tswallet-revokeSession.spec.tswallet-sessionChanged.spec.tsFiles Changed
e2e/tags.js- Removed 8 unused tags and their exportstests/tools/e2e-ai-analyzer/modes/select-tags/handlers.ts- Removed EXCLUDED_TAGS.github/workflows/run-e2e-smoke-tests-android.yml- Added SmokeMultiChainAPI job.github/workflows/run-e2e-smoke-tests-ios.yml- Added SmokeMultiChainAPI jobChangelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes Smart E2E tag selection and adds new smoke workflow jobs, which can alter CI coverage/runtime and potentially surface new flaky tests.
Overview
Adds
SmokeMultiChainAPIexecution to both Android and iOS smoke workflows (including it in the final report dependencies) so those tests can be selected and run in CI.Cleans up the Smart E2E tag source-of-truth by removing unused “reserved” smoke tags from
e2e/tags.jsand simplifyingSELECT_TAGS_CONFIGgeneration to no longer filter via anEXCLUDED_TAGSlist.Fixes multichain dapp navigation in
MultichainTestDApp.tsby resolving the local dapp URL at runtime viagetDappUrl(0)(avoiding early port allocation failures).Written by Cursor Bugbot for commit 2a98788. This will update automatically on new commits. Configure here.