Skip to content

chore: Bump transaction-pay-controller to ^12.0.2 and other related controllers#25376

Merged
dan437 merged 1 commit intomainfrom
transaction-pay-controller
Jan 30, 2026
Merged

chore: Bump transaction-pay-controller to ^12.0.2 and other related controllers#25376
dan437 merged 1 commit intomainfrom
transaction-pay-controller

Conversation

@dan437
Copy link
Copy Markdown
Contributor

@dan437 dan437 commented Jan 29, 2026

Description

Bump transaction-pay-controller to ^12.0.2

Release notes: https://github.com/MetaMask/core/blob/main/packages/transaction-pay-controller/CHANGELOG.md

Changelog

CHANGELOG entry: null

Related issues

Fixes: #25262

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Upgrades core transaction/payment-related controller dependencies, which can affect transaction submission, fees, and bridging behavior despite no app-code changes.

Overview
Bumps @metamask/transaction-pay-controller from ^11.1.0 to ^12.0.2.

Updates dependency resolution/lockfile to align with newer controller versions (notably @metamask/assets-controllers up to 99.1.0, @metamask/bridge-controller to 65.1.0, @metamask/bridge-status-controller to 65.0.1, and @metamask/transaction-controller to ^62.11.0), including adding a resolutions entry so the existing transaction-controller patch also applies to ^62.11.0.

Written by Cursor Bugbot for commit 812ad65. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 29, 2026
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 29, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​transaction-pay-controller@​11.1.0 ⏵ 12.0.299 +110080 +198 +1100

View full report

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

matthewwalsh0
matthewwalsh0 previously approved these changes Jan 29, 2026
@dan437 dan437 force-pushed the transaction-pay-controller branch 2 times, most recently from 319147f to 21755d6 Compare January 29, 2026 16:12
@dan437 dan437 requested review from a team as code owners January 29, 2026 16:12
@github-actions github-actions bot added size-S and removed size-XS labels Jan 29, 2026
@dan437 dan437 changed the title chore: Bump transaction-pay-controller to ^12.0.2 chore: Bump transaction-pay-controller to ^12.0.2 and other related controllers Jan 29, 2026
@dan437 dan437 force-pushed the transaction-pay-controller branch from 21755d6 to 30e4fce Compare January 29, 2026 17:41
@dan437 dan437 requested a review from a team as a code owner January 29, 2026 17:41
@dan437 dan437 force-pushed the transaction-pay-controller branch from 4a583a4 to 77e3653 Compare January 29, 2026 18:00
@MetaMask MetaMask deleted a comment from socket-security bot Jan 29, 2026
@dan437 dan437 force-pushed the transaction-pay-controller branch from 77e3653 to 90583af Compare January 29, 2026 18:05
@github-actions github-actions bot added size-XS and removed size-S labels Jan 29, 2026
Add resolution for ^62.11.0 to use patched transaction-controller.
@dan437 dan437 force-pushed the transaction-pay-controller branch from 90583af to 812ad65 Compare January 30, 2026 09:50
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmationsRedesigned, SmokeTrade
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: high
  • AI Confidence: 72%
click to see 🤖 AI reasoning details

E2E Test Selection:
package.json updates bump @metamask/transaction-pay-controller from ^11.1.0 to ^12.0.2 (major). This controller is integrated into Engine and widely used throughout the redesigned confirmations flow and swap/bridge flows. We verified many app imports of transaction-pay-controller in confirmations hooks/utils and Engine controller init/messengers, so a major version change can impact transaction confirmation UX, gas fee token payments, and swap confirmations. Also a new alias for @metamask/transaction-controller@^62.11.0 maps to a patched 62.9.0 to keep compatibility; runtime behavior of transaction-controller remains the same, but the engine still depends on this chain. To validate safely with minimal scope, run tests that exercise confirmations and trading flows which cover transaction execution and confirmation UI, including gas fee token payments and swap/bridge confirmations. Broader areas (accounts, network, snaps, perps, ramps, predictions) are not directly touched by these dependency changes.

Performance Test Selection:
No direct UI component rendering or state-management refactors; the change is a dependency bump for a controller used during confirmations. No indications of app startup, list rendering, or broad data-loading performance impact. Performance tests are not warranted for this change.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@dan437 dan437 enabled auto-merge January 30, 2026 10:40
@dan437 dan437 added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit 630e397 Jan 30, 2026
99 checks passed
@dan437 dan437 deleted the transaction-pay-controller branch January 30, 2026 11:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-XS team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Deposits failing due to being submitted with not enough ETH for gas

4 participants