fix(confirmations): handle batch predict deposits and quote‑based alerts by pedronfigueiredo · Pull Request #25326 · MetaMask/metamask-mobile

pedronfigueiredo · 2026-01-28T16:19:12Z

Update pay token selection to use hasTransactionType for predict deposit detection (covers nested/batch txs), and tighten typing/guarding around transactionMeta when updating selectedGasFeeToken. Perps behavior remains unchanged.
Suppress the native insufficient balance alert when the pay token matches the required token and pay‑controller quotes are loading/available, letting pay‑token balance/fee alerts drive blocking instead.
Add unit coverage for the quote‑present case and expand mocks for quote/loading state in useInsufficientBalanceAlert tests.

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes blocking alert behavior and updates how selectedGasFeeToken is set during pay-token selection for predictDeposit, which could impact confirmation gating and gas/token selection in edge cases.

Overview
Confirmation alerts now defer to transaction-pay UI when pay quotes/source amounts are in play. useInsufficientBalanceAlert stops emitting the native insufficient-balance blocking alert whenever useTransactionPayHasSourceAmount() indicates pay source amounts are being used, replacing the prior pay-token/required-token matching logic.

Pay-token selection for predictDeposit is more robust. useTransactionPayToken uses hasTransactionType to detect predictDeposit (covering nested/batch transactions) and only updates selectedGasFeeToken when transactionMeta is present, with tighter typing.

Tests for useInsufficientBalanceAlert were updated to mock useTransactionPayHasSourceAmount and cover the new suppression behavior.

^{Written by Cursor Bugbot for commit 567382e. This will update automatically on new commits. Configure here.}

github-actions · 2026-01-28T16:19:23Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/components/Views/confirmations/hooks/pay/useTransactionPayToken.ts

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

app/components/Views/confirmations/hooks/alerts/useInsufficientBalanceAlert.test.ts

matthewwalsh0 · 2026-01-30T11:18:19Z

app/components/Views/confirmations/hooks/alerts/useInsufficientBalanceAlert.ts

      !transactionMetadata ||
      isTransactionValueUpdating ||
-      (payToken && !isPayTokenTarget)
+      (payToken && !isPayTokenTarget && !isUsingPay)


Sorry for the confusion.

The goal here is to skip this alert if we're using MetaMask Pay with a quote.

So we'd want to return if isUsingPay is true.

And we shouldn't need payToken && !isPayTokenTarget since isUsingPay will only be true if there is a pay token, and the controller decided a quote is needed so generated a source amount.

matthewwalsh0 · 2026-01-30T11:20:42Z

app/components/Views/confirmations/hooks/alerts/useInsufficientBalanceAlert.ts

        (!isGasFeeTokensEmpty && !selectedGasFeeToken));

    const showAlert =
+      !shouldSkipInsufficientBalanceForPayToken &&


These changes shouldn't be needed as we can early return above with no alerts if isUsingPay.

…selection Use hasTransactionType so batch transactions containing predict/perps deposits are recognized when a payment token is selected. This keeps predict gasless selection working while leaving perps behavior unchanged.

Update selectedGasFeeToken for perps deposit transactions when the payment token matches the required token, so gasless relay can proceed without native ETH.

This reverts commit b8c2ac181a11300e992d8749edab921d9190cb43.

pedronfigueiredo · 2026-01-30T12:44:05Z

Tested scenarios:

Perps

USDC on Arbitrum
- Worked
BNB on Binance Chain
- Worked
USDC on Ethereum (without native token balance)
- Worked

Predict

USDC.e on Polygon
- Worked
BNB on Binance Chain
- trading route not available
USDC on ethereum
- Worked

github-actions · 2026-01-30T12:45:12Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeConfirmationsRedesigned, SmokePredictions, SmokeTrade
Selected Performance tags: None (no tests recommended)
Risk Level: medium
AI Confidence: 80%

click to see 🤖 AI reasoning details

E2E Test Selection:
Changes are localized to the confirmations flow: insufficient balance alert logic now short-circuits when Transaction Pay source amounts are used, and the pay token hook alters behavior for predictDeposit transactions using hasTransactionType and updates to selectedGasFeeToken typing. This directly impacts the redesigned confirmations experience and any flows that use Transaction Pay (gas fee token payments) such as swaps/bridge, and Predictions deposit confirmations. No Engine/controllers were changed, and scope is UI hooks, so broader suites are unnecessary.

Performance Test Selection:
Hook-level logic changes do not affect rendering complexity, startup, or list-heavy components. No state management/controller performance implications. Performance tests are unnecessary.

View GitHub Actions results

sonarqubecloud · 2026-01-30T13:08:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pedronfigueiredo self-assigned this Jan 28, 2026

pedronfigueiredo requested a review from a team as a code owner January 28, 2026 16:19

pedronfigueiredo added the team-confirmations Push issues to confirmations team label Jan 28, 2026

pedronfigueiredo changed the title ~~fix(confirmations): handle batch predict/perps deposits in pay token …~~ fix(confirmations): handle batch predict/perps deposits in pay token selection Jan 28, 2026

github-actions bot added the size-S label Jan 28, 2026

OGPoyraz previously approved these changes Jan 28, 2026

View reviewed changes

pedronfigueiredo dismissed OGPoyraz’s stale review via e385103 January 28, 2026 16:30

pedronfigueiredo force-pushed the pnf/gasless-perps branch 2 times, most recently from e385103 to 3d547d5 Compare January 28, 2026 16:30

pedronfigueiredo added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Jan 28, 2026

pedronfigueiredo requested a review from OGPoyraz January 28, 2026 16:34

OGPoyraz previously approved these changes Jan 28, 2026

View reviewed changes

pedronfigueiredo enabled auto-merge January 28, 2026 16:36

matthewwalsh0 requested changes Jan 28, 2026

View reviewed changes

app/components/Views/confirmations/hooks/pay/useTransactionPayToken.ts Outdated Show resolved Hide resolved

pedronfigueiredo disabled auto-merge January 28, 2026 16:39

matthewwalsh0 reviewed Jan 28, 2026

View reviewed changes

app/components/Views/confirmations/hooks/pay/useTransactionPayToken.ts Show resolved Hide resolved

pedronfigueiredo dismissed OGPoyraz’s stale review via f001a93 January 28, 2026 16:43

pedronfigueiredo requested review from OGPoyraz and matthewwalsh0 January 28, 2026 16:43

OGPoyraz previously approved these changes Jan 28, 2026

View reviewed changes

matthewwalsh0 previously approved these changes Jan 28, 2026

View reviewed changes

pedronfigueiredo enabled auto-merge January 28, 2026 17:10

pedronfigueiredo disabled auto-merge January 28, 2026 17:10

pedronfigueiredo enabled auto-merge January 28, 2026 17:27

pedronfigueiredo added this pull request to the merge queue Jan 28, 2026

pedronfigueiredo removed this pull request from the merge queue due to a manual request Jan 28, 2026

pedronfigueiredo marked this pull request as draft January 28, 2026 18:55

pedronfigueiredo dismissed matthewwalsh0’s stale review via a9c1cdf January 29, 2026 10:48

pedronfigueiredo force-pushed the pnf/gasless-perps branch from 1d211a9 to ad4e985 Compare January 29, 2026 18:13

cursor bot reviewed Jan 29, 2026

View reviewed changes

app/components/Views/confirmations/hooks/alerts/useInsufficientBalanceAlert.test.ts Outdated Show resolved Hide resolved

pedronfigueiredo force-pushed the pnf/gasless-perps branch from ad4e985 to 6d3dbbc Compare January 30, 2026 10:11

github-actions bot added size-M and removed size-S labels Jan 30, 2026

pedronfigueiredo requested review from OGPoyraz and matthewwalsh0 January 30, 2026 11:14

matthewwalsh0 requested changes Jan 30, 2026

View reviewed changes

matthewwalsh0 reviewed Jan 30, 2026

View reviewed changes

pedronfigueiredo added 10 commits January 30, 2026 12:43

address feedback

31546be

fix(confirmations): apply pay token to perps deposits

afae2c4

Update selectedGasFeeToken for perps deposit transactions when the payment token matches the required token, so gasless relay can proceed without native ETH.

Revert "fix(confirmations): apply pay token to perps deposits"

c93596a

This reverts commit b8c2ac181a11300e992d8749edab921d9190cb43.

bypass insufficient funds on perps

cb6d0e5

revert bypass and check the quotes

0d7a6f6

address feedback

789840b

address feedback

683bcb0

added unit test

55fbc35

Address feedback

567382e

pedronfigueiredo force-pushed the pnf/gasless-perps branch from 6d3dbbc to 567382e Compare January 30, 2026 12:43

matthewwalsh0 approved these changes Jan 30, 2026

View reviewed changes

pedronfigueiredo added this pull request to the merge queue Jan 30, 2026

Merged via the queue into main with commit f43252c Jan 30, 2026
89 checks passed

pedronfigueiredo deleted the pnf/gasless-perps branch January 30, 2026 15:10

github-actions bot locked and limited conversation to collaborators Jan 30, 2026

metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(confirmations): handle batch predict deposits and quote‑based alerts#25326

fix(confirmations): handle batch predict deposits and quote‑based alerts#25326
pedronfigueiredo merged 10 commits intomainfrom
pnf/gasless-perps

pedronfigueiredo commented Jan 28, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

matthewwalsh0 Jan 30, 2026

Uh oh!

matthewwalsh0 Jan 30, 2026

Uh oh!

pedronfigueiredo commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

sonarqubecloud bot commented Jan 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

pedronfigueiredo commented Jan 28, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matthewwalsh0 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

matthewwalsh0 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

pedronfigueiredo commented Jan 30, 2026

Tested scenarios:

Perps

Predict

Uh oh!

github-actions bot commented Jan 30, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud bot commented Jan 30, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pedronfigueiredo commented Jan 28, 2026 •

edited by cursor bot

Loading