feat: OmniSearch integration in WebBrowser#25312
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
NicolasMassart
left a comment
There was a problem hiding this comment.
Solid work, needs some refinement before merge.
…ts filtered by search queue > remaining of omni search
4c9d8c3 to
62d4079
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Caution MetaMask internal reviewing guidelines:
|
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis is a large PR with 100 changed files spanning multiple critical areas:
The changes to approval components (SignatureApproval, TransactionApproval) and RootRPCMethodsUI are particularly critical as they handle all transaction and signature confirmations. The Bridge and Earn changes are extensive and affect trading functionality. The CI workflow changes affect test infrastructure. |
|
|
Remade PR on a new branch due to main merge polluting this branch. New PR: #25358 |




PR Title
feat: integrate omni-search into in-app browser URL barDescription
This PR integrates the omni-search feature (originally developed for the Explore page) into the in-app browser's URL search bar.
Motivation
Changes
useExploreSearchhook intoUrlAutocompletecomponent with configurable section orderingPerpsConnectionProviderandPerpsStreamProviderTrendingTokenLogoandPerpsTokenLogofor consistent icon renderingAssetroute with proper slide-from-right animationTechnical Details
useExploreSearchto acceptsectionsOrderoption for flexible display orderingTokenSearchResulttype to includeassetIdfor proper logo renderingslip44:prefix) usingNATIVE_SWAPS_TOKEN_ADDRESSChangelog
CHANGELOG entry: Added omni-search integration to the in-app browser URL bar, allowing users to search for sites, tokens, perpetuals, and predictions directly from the browser
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
OmniSearchFunctionality.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Files Changed
Core Implementation
app/components/UI/UrlAutocomplete/index.tsx- Main autocomplete component with omni-search integrationapp/components/UI/UrlAutocomplete/Result.tsx- Updated result rendering with TrendingTokenLogo and PerpsTokenLogoapp/components/UI/UrlAutocomplete/types.ts- Added assetId to TokenSearchResult, added PerpsSearchResult and PredictionsSearchResultapp/components/UI/UrlAutocomplete/UrlAutocomplete.constants.ts- Added BROWSER_SEARCH_SECTIONS_ORDER and TOKEN_LOGO_API_BASE_URLHook Modifications
app/components/Views/TrendingView/hooks/useExploreSearch.ts- Added sectionsOrder option for flexible section orderingNavigation
app/components/Views/BrowserTab/BrowserTab.tsx- Updated onSelect handler for proper token navigation and search result preservationLocalization
locales/languages/en.json- Updated autocomplete section names for consistency ("Trending tokens", "Perps")Test Fixes
app/components/Views/DiscoveryTab/index.test.tsx- Added assetId to mock TokenSearchResultapp/components/Views/DiscoveryTab/DiscoveryTab.tsx- Fixed type checking for url propertyapp/components/Views/TrendingView/components/ExploreSearchResults/ExploreSearchResults.test.tsx- Added sectionsOrder to mock return values