feat: refactor token details page behind a feature flag by bergarces · Pull Request #25199 · MetaMask/metamask-mobile

bergarces · 2026-01-26T15:49:32Z

Description

Boilerplate for the Token Details V2 component that we are working on.

Hidden behind a feature flag disabled by default, so no observable changes to the client.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2487

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Default behavior remains the legacy Asset screen via a new tokenDetailsV2 flag (off by default), so user-visible impact is minimal. Some low risk remains from rerouting navigation to the new wrapper and introducing new hooks/transaction filtering code paths when the flag is enabled.

Overview
Adds a new TokenDetails V2 implementation (inline header + modular hooks for price, balances, actions, and transactions) and a presentation component (AssetOverviewContent) to compose the token overview UI.

Registers a new remote flag tokenDetailsV2 (default false) with selector selectTokenDetailsV2Enabled, and updates MainNavigator to route the Asset screen through the TokenDetails feature-flag wrapper (falling back to the legacy Asset view when disabled).

^{Written by Cursor Bugbot for commit 12598db. This will update automatically on new commits. Configure here.}

github-actions · 2026-01-26T15:49:42Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/components/UI/TokenDetails/Views/TokenDetails.tsx

app/components/UI/TokenDetails/components/TokenDetailsInlineHeader.tsx

app/components/UI/TokenDetails/Views/TokenDetails.test.tsx

app/components/UI/TokenDetails/components/AssetOverviewContent.tsx

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

app/components/UI/TokenDetails/hooks/useTokenTransactions.ts

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

app/components/UI/TokenDetails/Views/TokenDetails.test.tsx

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

app/components/UI/TokenDetails/hooks/useTokenActions.ts

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

app/components/UI/TokenDetails/hooks/useTokenActions.ts

bergarces · 2026-01-29T14:00:34Z

@Prithpal-Sooriya Regarding test comments. I have trimmed down down significantly. Hooks are now tested in a more comprehensive way. Bigger components still need tests.

app/components/UI/TokenDetails/hooks/useTokenBuyability.test.ts

Prithpal-Sooriya

Some tests are better than no tests. LGTM!

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

app/components/UI/TokenDetails/hooks/useTokenActions.ts

github-actions · 2026-01-29T19:18:56Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeAccounts, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokeRewards, SmokePerps, SmokeRamps, SmokePredictions, FlaskBuildTests
Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
Risk Level: high
AI Confidence: %

click to see 🤖 AI reasoning details

E2E Test Selection:
Fallback: AI analysis did not complete successfully. Running all tests.

Performance Test Selection:
Fallback: AI analysis did not complete successfully. Running all performance tests.

View GitHub Actions results

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

cursor · 2026-01-29T19:23:26Z

app/components/UI/TokenDetails/hooks/useTokenActions.ts

+
+    const wasHandledAsNonEvm = await sendNonEvmAsset(
+      InitSendLocation.AssetOverview,
+    );


sendNonEvmAsset undefined in non-keyring-snaps builds

High Severity

The sendNonEvmAsset variable is defined inside an ONLY_INCLUDE_IF(keyring-snaps) conditional block (lines 143-145), but it's used unconditionally at lines 207-209 and in the useCallback dependency array at line 245. In builds where keyring-snaps is not included, sendNonEvmAsset will be undefined, causing a ReferenceError when the onSend callback is created or invoked.

The existing AssetOverview.tsx uses the correct pattern: the hook is called unconditionally, and only the usage of sendNonEvmAsset is wrapped in the conditional block.

Additional Locations (2)

app/components/UI/TokenDetails/hooks/useTokenActions.ts#L142-L145

app/components/UI/TokenDetails/hooks/useTokenActions.ts#L244-L245

sonarqubecloud · 2026-01-29T19:40:15Z

Quality Gate failed

Failed conditions
26.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

bergarces added 3 commits January 23, 2026 11:11

initial commit

11e5ce6

Merge branch 'main' into token-details-v2

8e473cd

create wrapper

156e9f2

metamaskbot added the team-assets label Jan 26, 2026

github-actions bot added the size-M label Jan 26, 2026

copy component layout

c078667

github-actions bot added size-XL and removed size-M labels Jan 27, 2026

remove barrel files

828ec11

bergarces changed the title ~~Token-details-v2~~ feat: refactor token details page behind a feature flag Jan 27, 2026

bergarces added 2 commits January 27, 2026 12:55

remove console.log

dd40b12

codeowners

84768a6

bergarces marked this pull request as ready for review January 27, 2026 12:57

bergarces requested a review from a team as a code owner January 27, 2026 12:57

bergarces added 2 commits January 27, 2026 12:58

remove codeowners

5d6e669

Merge branch 'main' into token-details-v2

b669025

cursor bot reviewed Jan 27, 2026

View reviewed changes

app/components/UI/TokenDetails/Views/TokenDetails.tsx Outdated Show resolved Hide resolved

app/components/UI/TokenDetails/Views/TokenDetails.tsx Show resolved Hide resolved

feat: enable token details v2

ff0a694

cursor bot reviewed Jan 27, 2026

View reviewed changes

app/components/UI/TokenDetails/Views/TokenDetails.tsx Show resolved Hide resolved

better hooks

8d940c9

cursor bot reviewed Jan 27, 2026

View reviewed changes

app/components/UI/TokenDetails/Views/TokenDetails.tsx Outdated Show resolved Hide resolved

sahar-fehri reviewed Jan 27, 2026

View reviewed changes

app/components/UI/TokenDetails/Views/TokenDetails.tsx Outdated Show resolved Hide resolved

simplify logic for useTokenBalance

70200bb

cursor bot reviewed Jan 27, 2026

View reviewed changes

app/components/UI/TokenDetails/components/TokenDetailsInlineHeader.tsx Show resolved Hide resolved

tests

66c5967

cursor bot reviewed Jan 27, 2026

View reviewed changes

app/components/UI/TokenDetails/Views/TokenDetails.test.tsx Outdated Show resolved Hide resolved

bergarces added 2 commits January 28, 2026 11:43

warning message

9c321d7

remove hardcoded value

17bc0de

cursor bot reviewed Jan 28, 2026

View reviewed changes

app/components/UI/TokenDetails/components/AssetOverviewContent.tsx Show resolved Hide resolved

bergarces dismissed Prithpal-Sooriya’s stale review via 522dab5 January 29, 2026 09:50

cursor bot reviewed Jan 29, 2026

View reviewed changes

app/components/UI/TokenDetails/hooks/useTokenTransactions.ts Show resolved Hide resolved

simplify hook and tests

70929cf

cursor bot reviewed Jan 29, 2026

View reviewed changes

app/components/UI/TokenDetails/Views/TokenDetails.test.tsx Outdated Show resolved Hide resolved

bergarces added 3 commits January 29, 2026 12:11

tests for actions

dc82dfa

remove useless tests

a57ac63

remove more tests

29a0622

cursor bot reviewed Jan 29, 2026

View reviewed changes

app/components/UI/TokenDetails/hooks/useTokenActions.ts Show resolved Hide resolved

bergarces added 3 commits January 29, 2026 13:16

Merge branch 'main' into token-details-v2

1b0eff9

remove comments

4cb4313

merge from main

66f6991

cursor bot reviewed Jan 29, 2026

View reviewed changes

app/components/UI/TokenDetails/hooks/useTokenActions.ts Show resolved Hide resolved

bergarces added 2 commits January 29, 2026 13:49

missing features

209f37f

Merge branch 'main' into token-details-v2

6ab47d9

Prithpal-Sooriya reviewed Jan 29, 2026

View reviewed changes

app/components/UI/TokenDetails/hooks/useTokenBuyability.test.ts Show resolved Hide resolved

Prithpal-Sooriya approved these changes Jan 29, 2026

View reviewed changes

bergarces added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jan 29, 2026

Merge branch 'main' into token-details-v2

02c3bd7

cursor bot reviewed Jan 29, 2026

View reviewed changes

app/components/UI/TokenDetails/hooks/useTokenActions.ts Show resolved Hide resolved

Merge branch 'main' into token-details-v2

12598db

cursor bot reviewed Jan 29, 2026

View reviewed changes

bergarces added this pull request to the merge queue Jan 29, 2026

Merged via the queue into main with commit a23fb2e Jan 29, 2026
95 of 97 checks passed

bergarces deleted the token-details-v2 branch January 29, 2026 20:51

github-actions bot locked and limited conversation to collaborators Jan 29, 2026

metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 29, 2026

Uh oh!

Conversation

bergarces commented Jan 26, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bergarces commented Jan 29, 2026

Uh oh!

Uh oh!

Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 29, 2026

🔍 Smart E2E Test Selection

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 29, 2026

Choose a reason for hiding this comment

sendNonEvmAsset undefined in non-keyring-snaps builds

Uh oh!

sonarqubecloud bot commented Jan 29, 2026

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bergarces commented Jan 26, 2026 •

edited by cursor bot

Loading

`sendNonEvmAsset` undefined in non-keyring-snaps builds