Skip to content

chore: add builds.yml and optional Bitrise verification (no workflow impact)#25147

Merged
tommasini merged 12 commits intomainfrom
chore/bitrise-deprecation-refinement
Jan 30, 2026
Merged

chore: add builds.yml and optional Bitrise verification (no workflow impact)#25147
tommasini merged 12 commits intomainfrom
chore/bitrise-deprecation-refinement

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Jan 23, 2026

Description

Introduces a single source of truth for build configuration (.github/builds.yml) and supporting scripts so we can later migrate from Bitrise to GitHub Actions without changing behavior today.

What was added

  • .github/builds.yml – Defines all build variants (main-prod, main-rc, main-test, main-e2e, main-exp, main-dev, flask-prod, flask-test, flask-e2e, flask-dev) with env, secret mappings, code fencing, and remote feature flag defaults.
  • Scriptsvalidate-build-config.js (YAML validation), apply-build-config.js (load config and set env), set-secrets-from-config.js (map GitHub Secrets to env from config), and verify-build-config.js (compare Bitrise env with builds.yml).
  • Bitrise “Phase 1.5” step – Runs verify-build-config.js --verbose in selected workflows. This step is skippable and runs with || true, so it never fails the build. It only logs comparisons between Bitrise env and builds.yml for validation.

Important: no impact on existing workflow or Bitrise

  • Existing Bitrise env vars, remapping, and build steps are unchanged.
  • No step is removed or altered except for adding the optional Phase 1.5 verification.
  • The new step does not set or override env; it only reads and compares.
  • build_ios_flask_release was removed as a thin wrapper that only called build_ios_flask_prod; callers can use the prod workflow directly.

Reason for the change: Prepare for Bitrise deprecation by having build config in one place and validating parity between Bitrise and builds.yml before any migration.

Improvement: Clear, version-controlled build config and optional verification in CI without changing current Bitrise behavior or outcomes.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: Build config and Bitrise verification

Scenario: CI runs existing Bitrise workflows unchanged
Given a branch with this PR merged
When a Bitrise build runs (e2e, Android/iOS prod, etc.)
Then all existing steps run as before
And Phase 1.5 verification runs optionally (skippable, non-blocking)
And the build outcome is unchanged

Screenshots/Recordings

N/A – CI/config only; no UI changes.
Before
N/A
After
N/A

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
  • I've completed the PR template to the best of my ability.
  • I've included tests if applicable.
  • I've documented my code using JSDoc format if applicable.
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches CI/build configuration and removes a Bitrise workflow alias; while the new verification step is non-blocking, misconfiguration or missing callers could still disrupt build automation.

Overview
Adds a centralized .github/builds.yml to define build variants (env vars, secret mappings, code fencing, and default remote_feature_flags) plus accompanying Node scripts to validate/load/export this config (apply-build-config.js, validate-build-config.js, set-secrets-from-config.js, verify-build-config.js).

Updates bitrise.yml to run an optional, skippable Phase 1.5 parity check (verify-build-config.js --verbose || true) in key workflows, and drops the redundant build_ios_flask_release wrapper workflow. Also updates CODEOWNERS to protect .github/builds.yml and adds js-yaml as a dependency.

Written by Cursor Bugbot for commit fab10a9. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR only adds/updates CI/build infrastructure files and documentation: a dev dependency (js-yaml) in package.json, Bitrise workflow steps to run a non-strict verification script, and build config scripts/docs (.github/builds.* and scripts/verify-build-config.js). No app code, controllers, Engine, UI, or e2e code paths were changed. The GitHub Actions E2E workflows are unaffected; Bitrise additions run verification only and do not alter build variables used for E2E runs. Therefore, there is no functional or UX impact to validate via Detox, and running E2E would not meaningfully increase safety for this change.

Performance Test Selection:
No runtime app or rendering/state management changes. Only CI/build scripts and docs were modified; no potential performance impact.

View GitHub Actions results

@tommasini tommasini changed the title Chore: bitrise deprecation refinement chore: add builds.yml and optional Bitrise verification (no workflow impact) Jan 30, 2026
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 30, 2026
@tommasini tommasini marked this pull request as ready for review January 30, 2026 12:44
@tommasini tommasini requested a review from a team as a code owner January 30, 2026 12:44
@tommasini tommasini added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-mobile-platform Mobile Platform team and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 30, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

@sonarqubecloud
Copy link
Copy Markdown

@tommasini tommasini enabled auto-merge January 30, 2026 15:56
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tommasini tommasini added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit da89f62 Jan 30, 2026
98 of 102 checks passed
@tommasini tommasini deleted the chore/bitrise-deprecation-refinement branch January 30, 2026 18:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-XL team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants