Skip to content

fix(ramp): remove borders from deposit selectors for visual consistency#25128

Merged
wachunei merged 1 commit intomainfrom
fix/mdp-274-deposit-account-selector-styling
Jan 23, 2026
Merged

fix(ramp): remove borders from deposit selectors for visual consistency#25128
wachunei merged 1 commit intomainfrom
fix/mdp-274-deposit-account-selector-styling

Conversation

@wachunei
Copy link
Copy Markdown
Member

@wachunei wachunei commented Jan 23, 2026

Description

This PR addresses MDP-694 - "Fix the account selector background" (second action item from MDP-274).

Problem

The Deposit page selectors (Account, Region, Token, Payment Method) had visible borders that made them visually inconsistent with the Aggregator (Buy/Sell) flow selectors. The Deposit selectors used:

  • borderWidth: 1
  • borderColor: theme.colors.border.muted
  • Different background colors in some cases

This created a visual discrepancy between the two flows.

Solution

Updated the Deposit selector styles to match the Aggregator styling pattern:

  • Removed borders from all selector components
  • Updated background colors to use consistent background.muted token
  • Updated the payment duration tag to use background.subsection instead of a border

Files Changed

  1. AccountSelector.styles.ts

    • Removed borderWidth: 1 and borderColor from the selector style
  2. BuildQuote.styles.ts

    • fiatSelector: Changed background from background.default to background.muted, removed border
    • cryptoPill: Removed border (kept borderRadius: 100 for pill shape)
    • paymentMethodBox: Removed border, added background.muted
  3. BuildQuote.tsx

    • Updated TagBase component: Removed includesBorder prop, added custom background.subsection style

Changelog

CHANGELOG entry: fix: Updated Deposit page selectors to have consistent styling without borders

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MDP-694

Manual testing steps

Feature: Deposit Page Selector Styling

  Scenario: User views Account selector without border
    Given user is on the Deposit BuildQuote screen
    When user looks at the Account selector pill
    Then the Account selector has no visible border
    And the Account selector has a muted background color

  Scenario: User views Region selector without border
    Given user is on the Deposit BuildQuote screen
    When user looks at the Region/Country selector (flag icon)
    Then the Region selector has no visible border
    And the Region selector has a muted background color

  Scenario: User views Token selector without border
    Given user is on the Deposit BuildQuote screen
    When user looks at the Token selector pill (e.g., MUSD)
    Then the Token selector has no visible border
    And the Token selector maintains its pill shape

  Scenario: User views Payment Method section without border
    Given user is on the Deposit BuildQuote screen
    When user looks at the "Pay with" section
    Then the Payment Method box has no visible border
    And the duration tag (e.g., "Instant") has a subtle background instead of a border

  Scenario: Visual consistency with Aggregator flow
    Given user has seen the Aggregator (Buy/Sell) BuildQuote screen
    When user navigates to the Deposit BuildQuote screen
    Then the selector styling is visually consistent between both flows

Screenshots/Recordings

Before

before_mdp694

After

after_mdp694

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Aligns Deposit BuildQuote selector styling with Aggregator by removing borders and using consistent background tokens.

  • Updates AccountSelector, fiatSelector, cryptoPill, and paymentMethodBox to drop borders and use background.muted
  • Changes payment duration TagBase to use background.subsection instead of border
  • Refreshes snapshots to reflect new visual styles

Written by Cursor Bugbot for commit 375b043. This will update automatically on new commits. Configure here.

- Remove border from AccountSelector to match Aggregator styling
- Remove border from fiatSelector (region picker) and update background
- Remove border from cryptoPill (token selector)
- Remove border from paymentMethodBox and add muted background
- Update TagBase usage to remove border and use subsection background

Fixes second action item of MDP-274
@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Jan 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

This PR contains purely cosmetic/styling changes to the Ramp Deposit feature:

  1. BuildQuote.tsx: Removed includesBorder prop from TagBase component and added inline backgroundColor style
  2. BuildQuote.styles.ts: Changed background colors from default to muted, removed border styling (borderWidth, borderColor) from fiatSelector, regionContent, and paymentMethodBox styles
  3. AccountSelector.styles.ts: Removed border styling from the account selector container
  4. BuildQuote.test.tsx.snap: Snapshot updates reflecting the style changes

These changes:

  • Are purely visual (removing borders, changing background colors)
  • Do not affect any functionality, logic, or user flows
  • Do not modify any test IDs or accessibility labels used by E2E tests
  • Are confined to the Ramp Deposit feature's BuildQuote view

The E2E tests for Ramps (in e2e/specs/ramps/) use testIds for element selection (via BuildQuoteSelectors), not visual styling. The styling changes won't affect test element detection or any test assertions.

No E2E tests need to be run as these are low-risk cosmetic changes that cannot break any existing functionality or test flows.

View GitHub Actions results

@wachunei wachunei marked this pull request as ready for review January 23, 2026 19:18
@wachunei wachunei requested a review from a team as a code owner January 23, 2026 19:18
@sonarqubecloud
Copy link
Copy Markdown

@wachunei wachunei added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit 1949376 Jan 23, 2026
89 checks passed
@wachunei wachunei deleted the fix/mdp-274-deposit-account-selector-styling branch January 23, 2026 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 23, 2026
@metamaskbot metamaskbot added release-7.64.0 Issue or pull request that will be included in release 7.64.0 and removed release-7.65.0 Issue or pull request that will be included in release 7.65.0 labels Feb 3, 2026
@metamaskbot
Copy link
Copy Markdown
Collaborator

Missing release label release-7.64.0 on PR. Adding release label release-7.64.0 on PR and removing other release labels(release-7.65.0), as PR was added to branch 7.64.0 when release was cut.

@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.64.0 on PR, as PR was added to branch 7.64.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-S team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants