Skip to content

test: adds multiaccount v4 mocks#25094

Merged
christopherferreira9 merged 1 commit intomainfrom
cferreira/adds-accounts-v4-mocks
Jan 23, 2026
Merged

test: adds multiaccount v4 mocks#25094
christopherferreira9 merged 1 commit intomainfrom
cferreira/adds-accounts-v4-mocks

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Jan 23, 2026

Description

Adds mock for accounts api in multiaccount v4

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds coverage for the multi-account balances endpoint used in E2E tests.

  • New GET mock for v4/multiaccount/balances in tests/api-mocking/mock-responses/defaults/accounts.ts
  • Returns sample native balances for eip155:1 (ETH) and eip155:137 (MATIC) with unprocessedNetworks: ['eip155:1329']

Written by Cursor Bugbot for commit 183c81c. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jan 23, 2026
@christopherferreira9 christopherferreira9 requested a review from a team as a code owner January 23, 2026 11:08
@christopherferreira9 christopherferreira9 added the skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run label Jan 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@sonarqubecloud
Copy link
Copy Markdown

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit ee02bf7 Jan 23, 2026
210 of 244 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/adds-accounts-v4-mocks branch January 23, 2026 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2026
@metamaskbot metamaskbot added the release-7.64.0 Issue or pull request that will be included in release 7.64.0 label Jan 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-S skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants