Skip to content

feat: add retries to android system image install#25050

Merged
jvbriones merged 3 commits intomainfrom
cferreira/add-retry-android-system-images
Jan 23, 2026
Merged

feat: add retries to android system image install#25050
jvbriones merged 3 commits intomainfrom
cferreira/add-retry-android-system-images

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Jan 22, 2026 •
edited by cursor bot
Loading

Description

We've been having several occasions where the install of the Android System Images fail. This would lead to early failing tests with failures that are not related to the tests themselves.
The changes in this PR add a retry to this same install.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Introduces retries for Android system image installation in the E2E GitHub Actions workflow to reduce flaky setup failures.

  • Replaces direct run script with nick-fields/retry@v3.0.2 in run-e2e-workflow.yml for sdkmanager "system-images;android-34;google_apis;x86_64"
  • Configures retry with max_attempts: 3, retry_wait_seconds: 30, and timeout_minutes: 10

Written by Cursor Bugbot for commit 887beb1. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jan 22, 2026
@christopherferreira9 christopherferreira9 requested a review from a team as a code owner January 22, 2026 17:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 22, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 22, 2026
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]
cursor bot reviewed Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@christopherferreira9 christopherferreira9 marked this pull request as draft January 22, 2026 17:38
@christopherferreira9 christopherferreira9 marked this pull request as ready for review January 22, 2026 20:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 22, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

The change wraps the "Install Android System Images" step in the E2E workflow with a retry mechanism using the nick-fields/retry action. This is a CI infrastructure improvement that:

  1. No functional change: The actual command being executed (sdkmanager "system-images;android-34;google_apis;x86_64") remains exactly the same
  2. Established pattern: The nick-fields/retry action is already used 26 times across the codebase with the same version (v3.0.2), making this a proven and consistent pattern
  3. No application code affected: This change only affects CI workflow configuration, not any application code, test logic, or test files
  4. Resilience improvement only: The change adds retry capability (3 attempts, 10-minute timeout, 30-second wait) to handle transient network/download failures during Android system image installation

Since this is purely a CI reliability improvement with no changes to application code, test code, or test logic, no specific E2E tests need to be triggered. The workflow change will be validated naturally when any E2E tests run as part of the normal CI process.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 22, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jvbriones jvbriones enabled auto-merge January 23, 2026 08:26
@jvbriones jvbriones added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit 94a36d7 Jan 23, 2026
59 checks passed
@jvbriones jvbriones deleted the cferreira/add-retry-android-system-images branch January 23, 2026 09:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2026
@metamaskbot metamaskbot added the release-7.64.0 Issue or pull request that will be included in release 7.64.0 label Jan 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@jvbriones jvbriones jvbriones approved these changes

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-S team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christopherferreira9 @jvbriones @MarioAslau @metamaskbot