chore: do not build Hermes from source (-25% build time)#25035
Merged
sethkfman merged 2 commits intoMetaMask:chore/do-no-build-hermes-from-source-margelofrom Jan 22, 2026
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| } | ||
|
|
||
| installICULibraries(){ | ||
| # Install ICU libraries for Hermes |
There was a problem hiding this comment.
Redundant ICU installation steps remain in CI configuration
Low Severity
The installICULibraries function was removed from scripts/build.sh because Hermes is now fetched from Maven Central instead of built from source. However, bitrise.yml still contains two CI steps that install ICU libraries explicitly titled "Install ICU libraries for Hermes" (lines 2248-2254 and 2433-2439). These steps are now redundant and add unnecessary time to CI builds, partially negating the build time improvements this PR aims to achieve.
c6e4dbc
into
MetaMask:chore/do-no-build-hermes-from-source-margelo
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are patching only React Native Android source code so we don't need to build also Hermes engine which is adding lot of build time. On my machine it reduced build time by about 25% and I guess it could be even more on CI.
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Uses prebuilt Hermes to avoid compiling the engine from source, reducing Android build time and setup complexity.
ReactAndroid/build.gradle.kts) to depend oncompileOnly("com.facebook.react:hermes-android:0.76.9")and drop thehermes-enginepreBuild dependencyhermes-engineincludes/substitutions from RNsettings.gradle.ktsand appandroid/settings.gradle(resolve Hermes from Maven instead).yarn/patches/react-native-patch-d76d50a92f.patch) viapackage.jsonandyarn.lockprebuild_android()Written by Cursor Bugbot for commit 096aebf. This will update automatically on new commits. Configure here.