fix(predict): cp-7.63.0 add transaction validation and improve error handling#25013
fix(predict): cp-7.63.0 add transaction validation and improve error handling#25013
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThe changes are entirely focused on the Predict/Polymarket feature:
These changes are isolated to the Predict feature and don't touch any shared components (Browser, TabBar, Modals, Confirmations, etc.) that could affect other test suites. The SmokePredictions tag is the appropriate and only necessary tag to validate these changes, as it covers:
The risk is medium because while the changes improve error handling (which is positive), they also change behavior from silent failures to thrown errors, which could affect user flows if not properly handled. |
|



Description
Adds comprehensive validation for deposit transactions to prevent
silent failures causing 'not enough input to decode' errors.
Changes:
returning undefined
getProxyWalletAllowancesTransaction
Changelog
CHANGELOG entry: null
Related issues
Fixes: #24804
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Strengthens transaction reliability and diagnostics around Predict deposits and Polymarket Safe flows.
validateDepositTransactionsand invoke indepositWithConfirmation; logs transaction summary before submissionparams, validto(0x, 42 chars),dataexistence/hex format, and minimum data lengthgetDeployProxyWalletTransaction; wrapgetProxyWalletAllowancesTransactionin try/catch and validate call data lengthWritten by Cursor Bugbot for commit 4a9afd5. This will update automatically on new commits. Configure here.