chore: remove legacy accounts component code (pre BIP-44)#24886
Merged
chore: remove legacy accounts component code (pre BIP-44)#24886
Conversation
…to gar/chore/remove-legacy-bip44/components
…to gar/chore/remove-legacy-bip44/components
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24886 +/- ##
==========================================
+ Coverage 75.42% 80.26% +4.84%
==========================================
Files 4263 4263
Lines 110111 110086 -25
Branches 23462 23456 -6
==========================================
+ Hits 83051 88364 +5313
+ Misses 21036 15519 -5517
- Partials 6024 6203 +179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…thub.com/MetaMask/metamask-mobile into gar/chore/remove-legacy-bip44/components
Member
Author
|
Won't fix the quality gate failure since this is not introducing any new code |
sahar-fehri
reviewed
Jan 28, 2026
app/components/Views/MultichainAccounts/AccountDetails/components/AccountInfo/AccountInfo.tsx
Show resolved
Hide resolved
sahar-fehri
previously approved these changes
Jan 28, 2026
Contributor
sahar-fehri
left a comment
There was a problem hiding this comment.
Assets changes LGTM ✅
ccharly
previously approved these changes
Jan 29, 2026
mathieuartu
previously approved these changes
Jan 29, 2026
sahar-fehri
previously approved these changes
Jan 29, 2026
…thub.com/MetaMask/metamask-mobile into gar/chore/remove-legacy-bip44/components
1d5030f
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|
sahar-fehri
approved these changes
Jan 30, 2026
ccharly
approved these changes
Jan 30, 2026
montelaidev
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the usage of the selector
selectMultichainAccountsState2Enabledwhich gets the value for the BIP-44 feature flag. Moving forward, BIP-44 is the default behaviour and any alternative logic branch will be remove alongside tests.The scope of the changes is limited to files inside the
app/components/UI/directory.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1382
Manual testing steps
Not applicable
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Removes legacy/flagged UI branches and changes user-visible behavior (e.g.,
AddressCopyno longer copies to clipboard and network selector defaults/sections change). Moderate risk of regressions in navigation, balance display, and tests due to widened unconditional paths.Overview
Standardizes UI on multichain/BIP-44 behavior by removing
selectMultichainAccountsState2Enabledgating.AddressCopyis simplified to no longer accept anaccountprop and no longer performs clipboard/toast/metrics/protect-wallet logic; pressing the icon now always navigates to the multichain address list (updated call sites inNavbarandAccountInfo, plus a simplified test).Network selection UI is de-flagged:
NetworkManager’s initial tab selection is now derived solely fromenabledNetworksByNamespace,NetworkMultiSelectoralways renders the custom network section for any namespace, andNetworkMultiSelectorListalways prepends the “select all networks” row when provided.AssetOverviewdrops the state2-specific balance shortcut and always usesasset.balancewhen present; tests are updated accordingly (mock selectors refactor, Solana balance expectation, and an updated “no balance” scenario).Written by Cursor Bugbot for commit 0516e6e. This will update automatically on new commits. Configure here.