Skip to content

fix: Fix Snaps E2E after browser UX changes#24729

Merged
FrederikBolding merged 1 commit intomainfrom
fb/fix-snaps-e2e-broken-on-main
Jan 16, 2026
Merged

fix: Fix Snaps E2E after browser UX changes#24729
FrederikBolding merged 1 commit intomainfrom
fb/fix-snaps-e2e-broken-on-main

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Jan 16, 2026

Description

Fix Snaps E2Es which are currently blocking main due to not being run on an earlier PR which introduced new UX that the E2Es aren't designed for.

Changelog

CHANGELOG entry: null


Note

Updates Snap management E2E tests to align with new browser UX.

  • Adds BrowserView import and calls BrowserView.tapCloseBrowserButton() before navigating to Settings in the disable/enable/remove Snap tests to ensure the browser view is closed prior to settings navigation

Written by Cursor Bugbot for commit bf0d93d. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner January 16, 2026 09:35
@metamaskbot metamaskbot added team-core-platform Core Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: FlaskBuildTests
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

The change is limited to a single E2E test file in the snaps directory (e2e/specs/snaps/test-snap-management.spec.ts). The modifications are minimal:

  1. Added import for BrowserView
  2. Added await BrowserView.tapCloseBrowserButton(); at the beginning of three test cases ('can disable a Snap', 'can enable a Snap', 'can remove a Snap')

This appears to be a test fix to properly close the browser before navigating to settings, likely addressing a test flakiness or flow issue. The test file explicitly uses the FlaskBuildTests tag in its describe block, so running FlaskBuildTests is the appropriate choice to verify these test changes work correctly.

No application code is modified, so there's no risk to the actual app functionality. The risk is low because this is purely a test infrastructure change that improves test reliability.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@FrederikBolding FrederikBolding added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit 30d9210 Jan 16, 2026
109 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-snaps-e2e-broken-on-main branch January 16, 2026 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
@metamaskbot metamaskbot added the release-7.63.0 Issue or pull request that will be included in release 7.63.0 label Jan 16, 2026
@metamaskbot metamaskbot added release-7.62.0 Issue or pull request that will be included in release 7.62.0 and removed release-7.63.0 Issue or pull request that will be included in release 7.63.0 labels Jan 26, 2026
@metamaskbot
Copy link
Copy Markdown
Collaborator

Missing release label release-7.62.0 on PR. Adding release label release-7.62.0 on PR and removing other release labels(release-7.63.0), as PR was cherry-picked in branch 7.62.0.

@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.62.0 on PR, as PR was cherry-picked in branch 7.62.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XS team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants