Skip to content

fix: remove block explorer link for uncomplete intent swap cp-7.62.0#24582

Merged
oscarwroche merged 3 commits intomainfrom
fix/BETR-233
Jan 16, 2026
Merged

fix: remove block explorer link for uncomplete intent swap cp-7.62.0#24582
oscarwroche merged 3 commits intomainfrom
fix/BETR-233

Conversation

@Akaryatrh
Copy link
Copy Markdown
Contributor

@Akaryatrh Akaryatrh commented Jan 15, 2026

Description

Removes block url link from intent based swap item (Activity panel) when the status is not complete (only complete intent swap gets a tx hash )

Changelog

CHANGELOG entry: remove block explorer link for uncomplete intent swap

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/BETR-233

Manual testing steps

  • go to swap page
  • swap USDC to APPLON
  • go to pending swap details and see that the block url button is NOT displayed
  • wait for swap completion
  • go to completed swap details and see that the block url button is displayed

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Prevents showing a block explorer link for intent-based swaps until they are completed.

  • Adds isIntentNotCompletedItem check in TransactionDetails.tsx based on quote.intent and StatusTypes.COMPLETE
  • Conditionally renders the "View on block explorer" button only when the item is not an incomplete intent swap
  • Keeps existing navigation: swaps open source tx in-browser; bridges open the block explorer modal

Written by Cursor Bugbot for commit 45e9d9e. This will update automatically on new commits. Configure here.

@Akaryatrh Akaryatrh added the team-swaps-and-bridge Swaps and Bridge team label Jan 15, 2026
@Akaryatrh Akaryatrh requested a review from a team as a code owner January 15, 2026 18:10
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Akaryatrh Akaryatrh changed the title fix: remove block explorer link for uncomplete intent swap fix: remove block explorer link for uncomplete intent swap cp-7.62.0 Jan 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

The change is a small, focused UI modification in the Bridge Transaction Details component. It introduces a new conditional variable isIntentNotCompletedItem that hides the "View on Block Explorer" button when a transaction is an intent type that hasn't completed yet. This is a straightforward conditional rendering change that:

  1. Only affects the Bridge Transaction Details view
  2. Doesn't modify any core logic, controllers, or critical paths
  3. Has clear, simple logic (checking if quote.intent exists AND status is not COMPLETE)
  4. Is isolated to a single UI component

The SmokeTrade tag is appropriate because:

  • The bridge-action-smoke.spec.ts test file explicitly uses the SmokeTrade tag
  • Bridge functionality is part of the Trade/Swap features
  • The test verifies bridge transactions complete successfully and appear in the activity view

No other tags are needed as this change doesn't affect:

  • Account management (SmokeAccounts)
  • Confirmations (SmokeConfirmationsRedesigned)
  • Identity/sync features (SmokeIdentity)
  • Network abstractions or expansion (SmokeNetworkAbstractions, SmokeNetworkExpansion)
  • Core wallet platform features (SmokeWalletPlatform)
  • Card, Rewards, Perps, Ramps, or Predictions features
  • Snaps functionality (FlaskBuildTests)

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@oscarwroche oscarwroche added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit 6c24d58 Jan 16, 2026
144 of 146 checks passed
@oscarwroche oscarwroche deleted the fix/BETR-233 branch January 16, 2026 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
@metamaskbot metamaskbot added the release-7.63.0 Issue or pull request that will be included in release 7.63.0 label Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.63.0 Issue or pull request that will be included in release 7.63.0 size-S team-accounts-framework Accounts team team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants