Skip to content

chore: adds Tron learn more modal cp-7.62.0#24556

Merged
zone-live merged 6 commits intomainfrom
NWNT-tron-staking-learn-more-modal
Jan 16, 2026
Merged

chore: adds Tron learn more modal cp-7.62.0#24556
zone-live merged 6 commits intomainfrom
NWNT-tron-staking-learn-more-modal

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

@zone-live zone-live commented Jan 15, 2026 •
edited by cursor bot
Loading

Description

Adds Tron Learn More modal (TronStakingLearnMoreModal) that displays TRX staking information when users taps the info icon during Tron staking. The button "learn more" takes to the general stake crypto article from MM.

Screenshot 2026-01-15 at 13 40 54
Screen.Recording.2026-01-15.at.13.52.09.mov

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Introduces a dedicated TRX staking info modal and consolidates shared staking modal UI.

  • Adds TronStakingLearnMoreModal with APY display, analytics, and tracing; includes styles and tests
  • Wires TRX modal navigation from EarnInputView when staking TRX and registers Routes.STAKING.MODALS.TRX_LEARN_MORE
  • Extracts reusable LearnMoreModalFooter and StakingInfoBodyText; updates PoolStakingLearnMoreModal to use them and removes duplicate footer/body logic
  • Updates staking routes to include the new TRX modal; adds corresponding i18n strings
  • Minor: traces end on APY load for both ETH/TRX modals; keeps existing pooled staking and lending flows intact

Written by Cursor Bugbot for commit 7d7eb9d. This will update automatically on new commits. Configure here.

@zone-live zone-live requested a review from a team as a code owner January 15, 2026 13:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 15, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-networks Networks team label Jan 15, 2026
@zone-live zone-live changed the title chore: adds Tron learn more modal chore: adds Tron learn more modal cp-7.62.0 Jan 15, 2026
cursor[bot]
cursor bot reviewed Jan 15, 2026
View reviewed changes
@zone-live zone-live added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jan 15, 2026
@github-actions github-actions bot added size-L and removed size-M labels Jan 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 15, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

This PR introduces a new Tron Staking Learn More Modal feature with the following changes:

  1. New TronStakingLearnMoreModal component - A new modal specifically for TRX staking information, including styles and unit tests
  2. Refactored shared components - Extracted LearnMoreModalFooter and StakingInfoBodyText from PoolStakingLearnMoreModal for reuse
  3. Navigation updates - Added new route TRX_LEARN_MORE and navigation logic in EarnInputView.tsx
  4. Localization - Added new strings for TRX staking modal

Key observations:

  • All Tron-specific code is wrapped in feature flags (///: BEGIN:ONLY_INCLUDE_IF(tron))
  • The refactoring of PoolStakingLearnMoreModal maintains the same functionality while extracting reusable components
  • No changes to core wallet functionality, controllers, or Engine
  • The existing stake E2E test (stake-action-smoke.spec.ts) uses the SmokeTrade tag

The SmokeTrade tag is appropriate because:

  • The stake E2E test is tagged with SmokeTrade
  • The changes affect staking/earn UI components and navigation
  • This will verify that the existing staking flow still works after the refactoring

Risk is low because:

  • Changes are mostly additive (new modal)
  • Feature is behind a feature flag
  • Refactoring maintains existing behavior
  • Unit tests are included for the new component

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 15, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zone-live zone-live added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit 2c6068c Jan 16, 2026
83 checks passed
@zone-live zone-live deleted the NWNT-tron-staking-learn-more-modal branch January 16, 2026 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
@metamaskbot metamaskbot added the release-7.63.0 Issue or pull request that will be included in release 7.63.0 label Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@shane-t shane-t shane-t approved these changes

Assignees

No one assigned

Labels

release-7.63.0 Issue or pull request that will be included in release 7.63.0 size-L skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-networks Networks team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zone-live @shane-t @metamaskbot