fix: regex in typed-data parsing cp-7.62.0#24550
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
dc6d46c to
ad592b0
Compare
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThe PR contains three changes:
The signature utility is imported by 20+ files in the confirmations flow including typed sign components, personal sign, permit simulations, and blockaid banner. This warrants running SmokeConfirmationsRedesigned tests to verify the signature parsing and display functionality works correctly with the security fix. Risk is medium because:
|
|



Description
Fix regex in typed-data parsing.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6624
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Strengthens typed-data parsing to prevent UI spoofing from nested
valuefields.REGEX_MESSAGE_VALUE_LARGEto use[^{}]*so only top-levelmessage.valueis matched, ensuring large numbers are parsed correctly from the intended fieldvaluefields, arrays, ordering, escaped quotes, and string-valuedmessage.valuehttps://api.hyperliquid.xyz/infoWritten by Cursor Bugbot for commit ad592b0. This will update automatically on new commits. Configure here.