Skip to content

chore: remove environment specific naming in action#24388

Merged
sethkfman merged 66 commits intomainfrom
chore/update-env-mapping-eas
Jan 15, 2026
Merged

chore: remove environment specific naming in action#24388
sethkfman merged 66 commits intomainfrom
chore/update-env-mapping-eas

Conversation

@sethkfman
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman commented Jan 9, 2026 •
edited by cursor bot
Loading

Description

This PR updates the push-eas-update workflow:

  • added new env mapping to accept all env values needed to build RC and Production applications
  • removes yarn cache restore
  • addresses PR hash pinning and validation

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Introduces commit-hash–based publishing with validation and tightens OTA workflow gating.

  • Adds ./.github/scripts/validate-pr-commit.sh to verify COMMIT_HASH is the PR head and base branch matches
  • Updates push-eas-update.yml to accept commit_hash, check out the exact commit for fingerprinting and publishing, and record fingerprints for that commit vs BASE_BRANCH
  • New validate-pr job exposes validated pr_number for the approval step; approval and push-update now depend on both fingerprint match and successful validation
  • Streamlines steps (removes yarn cache hints and extraneous output), expands env/secret mappings, and adjusts summary outputs

Written by Cursor Bugbot for commit e7e0b87. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Jan 9, 2026
@github-actions github-actions bot added the size-S label Jan 9, 2026
@github-actions github-actions bot added size-M and removed size-S labels Jan 10, 2026
@weitingsun weitingsun requested a review from a team as a code owner January 15, 2026 11:44
cursor[bot]
cursor bot reviewed Jan 15, 2026
View reviewed changes
tommasini
tommasini reviewed Jan 15, 2026
View reviewed changes
.github/workflows/setup-node-modules.yml Outdated
with:
node-version: '20'

- name: Enable Corepack
Copy link
Copy Markdown
Contributor

@tommasini tommasini Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need enable corepack at the end of day

tommasini
tommasini reviewed Jan 15, 2026
View reviewed changes
.github/workflows/push-eas-update.yml Outdated
- name: Enable Corepack
run: corepack enable && corepack prepare yarn@4.10.3 --activate

- name: Clear yarn state before artifact download
Copy link
Copy Markdown
Contributor

@tommasini tommasini Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly sure that we don't need to clear the state either before downloading node modules since the reason why it was failing it was the state.tz file

tommasini
tommasini reviewed Jan 15, 2026
View reviewed changes
cursor[bot]
cursor bot reviewed Jan 15, 2026
View reviewed changes
cursor[bot]
cursor bot reviewed Jan 15, 2026
View reviewed changes
cursor[bot]
cursor bot reviewed Jan 15, 2026
View reviewed changes
sethkfman
sethkfman commented Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @weitingsun updates

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 15, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

The changes are limited to GitHub Actions CI/CD infrastructure:

  1. .github/scripts/validate-pr-commit.sh - A new shell script that validates commit hashes against PR heads using the GitHub API. This is purely a CI utility script with no impact on the application code or E2E tests.

  2. .github/workflows/push-eas-update.yml - Modifications to the OTA update workflow to:

    • Accept a commit hash input instead of just PR number
    • Add a validation step to ensure the commit is the HEAD of the specified PR
    • Update checkout steps to use commit hash directly
    • Remove yarn cache configuration
    • Update job dependencies

These changes:

  • Do not modify any application source code
  • Do not affect E2E test infrastructure (Detox, wdio, or appwright)
  • Do not change any user-facing features
  • Are isolated to the OTA update deployment workflow

Since these are purely CI/CD workflow changes that don't touch the mobile application code or test infrastructure, no E2E tests need to be run to validate these changes.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 15, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Cal-L
Cal-L approved these changes Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit 8aa7f79 Jan 15, 2026
57 checks passed
@sethkfman sethkfman deleted the chore/update-env-mapping-eas branch January 15, 2026 22:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2026
@metamaskbot metamaskbot added the release-7.63.0 Issue or pull request that will be included in release 7.63.0 label Jan 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini left review comments

@cursor cursor[bot] cursor[bot] left review comments

@Cal-L Cal-L Cal-L approved these changes

@weitingsun weitingsun weitingsun approved these changes

+1 more reviewer

@NEllusion NEllusion NEllusion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.63.0 Issue or pull request that will be included in release 7.63.0 size-M team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sethkfman @codecov-commenter @Cal-L @NEllusion @tommasini @weitingsun @metamaskbot