Skip to content

test: enable previously skipped test for claiming winnings via market details#24277

Merged
chrisleewilcox merged 1 commit intomainfrom
test-enable-predict-claim
Jan 7, 2026
Merged

test: enable previously skipped test for claiming winnings via market details#24277
chrisleewilcox merged 1 commit intomainfrom
test-enable-predict-claim

Conversation

@chrisleewilcox
Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox commented Jan 6, 2026 •
edited
Loading

Description

This commit re-enables the test for claiming winnings through market details, which was previously skipped due to blocking CI. The test is now active and will run as part of the CI pipeline.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: Claim Prediction Winnings
  As a user with winning prediction positions
  I want to claim my winnings from market details
  So that I can receive my earnings

  Background:
    Given the user is logged into the MetaMask app
    And the user has a winning prediction position
    And the user has a lost prediction position
    And the Predictions feature is enabled

  Scenario: Claim button is not visible on lost positions
    Given the user is on the Predictions tab
    When the user taps on a lost position
    Then the market details page should be visible
    And the Claim button should not be visible

  Scenario: Claim button is visible on winning positions
    Given the user is on the Predictions tab
    When the user taps on a winning position
    Then the market details page should be visible
    And the Claim button should be visible

  Scenario: Successfully claim winnings via market details
    Given the user is on the Predictions tab
    And the user has navigated to a winning position's details
    When the user taps the Claim Winnings button
    And the user confirms the claim transaction
    Then the Claim button should no longer be visible on the details page
    And the user should be returned to the wallet view
    And the Claim button should not be visible on the Predictions tab
    And all resolved positions should be removed from the UI
    And the balance should be updated to "$48.16"

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Scope

  • Unskips claim winnings via market details E2E in e2e/specs/predict/predict-claim-positions.spec.ts by changing it.skip to it.

What the test covers

  • Claims winnings from a winning position’s details page, verifies claim button visibility rules, applies post-claim mocks, and confirms UI updates (no claim button, resolved positions removed, balance $48.16).

Written by Cursor Bugbot for commit 0a3b29e. This will update automatically on new commits. Configure here.

@chrisleewilcox
test: enable previously skipped test for claiming winnings via market…
0a3b29e 
… details

This commit re-enables the test for claiming winnings through market details, which was previously skipped due to blocking CI. The test is now active and will run as part of the CI pipeline.
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner January 6, 2026 23:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions
  • Risk Level: low
  • AI Confidence: 98%
click to see 🤖 AI reasoning details

The change is a single-line modification in an E2E test file that re-enables a previously skipped test by changing it.skip to it. The test file predict-claim-positions.spec.ts is tagged with SmokePredictions (imported from ../../tags and used in the describe block). This test verifies the claim winnings flow for predictions/Polymarket positions. Since no application code is changed and this is purely enabling an existing test, the risk is low. Only the SmokePredictions tag is needed to verify this change works correctly.

View GitHub Actions results

@chrisleewilcox chrisleewilcox added No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Jan 6, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 7, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chrisleewilcox chrisleewilcox added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 3d176a3 Jan 7, 2026
138 of 142 checks passed
@chrisleewilcox chrisleewilcox deleted the test-enable-predict-claim branch January 7, 2026 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matallui matallui matallui approved these changes

@cortisiko cortisiko cortisiko approved these changes

@LeVinhGithub LeVinhGithub LeVinhGithub approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XS team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chrisleewilcox @matallui @cortisiko @LeVinhGithub @metamaskbot