chore: add subtitle to Headers and increase height to 56px#24268
chore: add subtitle to Headers and increase height to 56px#24268brianacnguyen merged 5 commits intomainfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
...nent-library/components-temp/HeaderWithTitleLeftScrollable/HeaderWithTitleLeftScrollable.tsx
Show resolved
Hide resolved
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis PR makes UI changes to core header components (HeaderBase, HeaderCenter, HeaderWithTitleLeftScrollable) that affect the visual appearance across the entire application:
The changes are purely visual/UI and don't affect business logic, but the header height change could potentially cause layout issues in various screens. The affected areas include:
Selected tags cover the major feature areas where header components are used to ensure the height change doesn't cause visual regressions. |
|
vinnyhoward
left a comment
There was a problem hiding this comment.
Nice work! I like the flexibility. Only non-blocking issue I see is the Cursor bot bug about the potential clipping issue. I see that you dismissed it so I assume its not an issue?
I fixed it |
|
|
||
| const DEFAULT_EXPANDED_HEIGHT = 140; | ||
| const DEFAULT_COLLAPSED_HEIGHT = 48; | ||
| const DEFAULT_COLLAPSED_HEIGHT = 56; |



Description
This PR enhances the
HeaderCenterandHeaderWithTitleLeftScrollablecomponents with additional functionality:Added subtitle support - Both components now support an optional
subtitleprop that renders below the title with center alignment, along withsubtitlePropsfor customization.Extended HeaderBase props - Removed the
Omitconstraints from both components:HeaderCenternow extendsHeaderBasePropsdirectly (previously omittedstartButtonIconProps)HeaderWithTitleLeftScrollablenow extendsHeaderBasePropsdirectly (previously omittedchildren)Added
titlePropsto HeaderWithTitleLeftScrollable - Allows customization of the compact header title.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-01-06.at.08.55.57.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces subtitle support and raises the compact header height across header components.
HeaderCenter: addssubtitleandsubtitleProps; stacks title + subtitle centered; storyWithSubtitleand tests for rendering/propsHeaderWithTitleLeftScrollable: addstitleProps,subtitle,subtitleProps, andchildrenhandling in compact header; new tests for subtitle and children precedence; stories updated (WithSubtitle,OnClose,BackAndClose)HeaderBase(h-12→h-14) andHeaderWithTitleLeftScrollableDEFAULT_COLLAPSED_HEIGHTto56; updates numerous snapshots accordinglyHeaderBasePropsand resolve start/end buttons (back/close) consistentlyWritten by Cursor Bugbot for commit dd0c826. This will update automatically on new commits. Configure here.