Skip to content

chore(predict): add disclaimer to market about tab#24265

Merged
matallui merged 1 commit intomainfrom
predict/about-disclaimer
Jan 6, 2026
Merged

chore(predict): add disclaimer to market about tab#24265
matallui merged 1 commit intomainfrom
predict/about-disclaimer

Conversation

@matallui
Copy link
Copy Markdown
Contributor

@matallui matallui commented Jan 6, 2026

Description

This PR adds a disclaimer to the "About" tab on the Predict market details page.

Reason for change:
Users need to be informed that the market information displayed may be incomplete and that all market rules, resolution criteria, and final outcomes are governed by Polymarket.

Solution:
Added a disclaimer text section below the market description in the About tab, separated by a horizontal divider. The disclaimer directs users to Polymarket for the full rules before making trades.

Changelog

CHANGELOG entry: Added disclaimer to Predict market details About tab informing users to check Polymarket for full market rules

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/PRED-386

Manual testing steps

Feature: Predict Market Details Disclaimer

  Scenario: user views market About tab
    Given user has Predict enabled
    And user is on a Predict market details screen

    When user scrolls to the About section
    Then user sees the market description
    And user sees a disclaimer below the description stating market info may be incomplete and rules are governed by Polymarket

Screenshots/Recordings

Before

After

simulator_screenshot_1BDF6804-092E-4394-9D94-E3071EBD51EB

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds a short legal disclaimer to the Predict market details About section.

  • Updates PredictMarketDetails.tsx to render a divider and Text with strings('predict.market_details.disclaimer') beneath the market description
  • Adds predict.market_details.disclaimer to locales/languages/en.json

Written by Cursor Bugbot for commit 14b3b27. This will update automatically on new commits. Configure here.

@matallui matallui requested a review from a team as a code owner January 6, 2026 15:42
@matallui matallui added the team-predict Predict team label Jan 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

The changes are minimal and localized to the Predictions feature:

  1. PredictMarketDetails.tsx: Adds a simple UI element - a border separator and disclaimer text to the market details view. This is a purely additive change with no logic modifications.

  2. en.json: Adds a new localization string for the disclaimer text.

These changes:

  • Are purely UI/text additions
  • Don't modify any business logic, navigation, or state management
  • Are isolated to the Predict module
  • Don't affect any core wallet functionality

The SmokePredictions tag is appropriate because:

  • There are existing E2E tests in e2e/specs/predict/ that cover the Predictions feature
  • These tests will verify the market details view still renders correctly
  • The tests cover various prediction scenarios (claim positions, cash out, open position, geo-restriction, API down states)

No other tags are needed as the changes don't touch any other features or core functionality.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@matallui matallui added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jan 6, 2026
@matallui matallui added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit bfd13d7 Jan 6, 2026
182 of 185 checks passed
@matallui matallui deleted the predict/about-disclaimer branch January 6, 2026 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XS skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-predict Predict team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants