Skip to content

chore: update network fee tooltip for gas fees sponsored case#24258

Merged
Battambang merged 3 commits intomainfrom
gas-fees-sponsored2
Jan 7, 2026
Merged

chore: update network fee tooltip for gas fees sponsored case#24258
Battambang merged 3 commits intomainfrom
gas-fees-sponsored2

Conversation

@Battambang
Copy link
Copy Markdown
Contributor

@Battambang Battambang commented Jan 6, 2026 •
edited
Loading

Description

Enhances the gas fee sponsorship user experience by updating the tooltip logo and content next to "network fee" to align with the other tooltip logo in the swap quote card.

Problem

There was a different tooltip logo for gas fees sponsored swaps in the swap quote card.
The send transaction modal is missing the gas fees sponsored content network fee tooltip.

Solution

Implement a UI-level workaround that updates the tooltip logo next to "network fee" in the swap quote card.
Add the the gas fees sponsored content network fee tooltip for send transaction.

Changelog

CHANGELOG entry: updated network fee tooltip for gas fees sponsored case

Related issues

Fixes: null

Manual testing steps

  1. Go to the swap page.
  2. Request a same chain swap quote on a chain eligible of gas fees sponsored.
  3. The quote response for network fees should display the correct tooltip logo.
  4. The send transaction network fee tooltip should display the specific text for gas fees sponsored case.

Screenshots/Recordings

Before

Mobile before

After

Mobile after Monad send mob

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Standardizes the “network fee” tooltip for sponsored gas cases.

  • Bridge QuoteDetailsCard: sets tooltip iconName to Info for network_fee when gas fees are sponsored.
  • Confirmations gas-fee-details-row: updates tooltip content to bridge.network_fee_info_content_sponsored, injecting the native token symbol (resolved via selectNetworkConfigurationByChainId with useNetworkInfo fallback).

Written by Cursor Bugbot for commit 49bf386. This will update automatically on new commits. Configure here.

@Battambang Battambang requested a review from a team as a code owner January 6, 2026 09:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the size-S label Jan 6, 2026
@Battambang Battambang force-pushed the gas-fees-sponsored2 branch from de672a4 to 842abc4 Compare January 6, 2026 10:42
@github-actions github-actions bot added size-XS and removed size-S labels Jan 6, 2026
@Battambang Battambang added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jan 6, 2026
@Battambang
Copy link
Copy Markdown
Contributor Author

Battambang commented Jan 6, 2026

Skipping Sonar Cloud since the 3 smell codes reported are tagged as new issue while they are there since several months ago and also they are not related to the code that has been updated.

@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Jan 6, 2026
@Battambang Battambang added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Jan 6, 2026
@Battambang Battambang force-pushed the gas-fees-sponsored2 branch from 842abc4 to b0ab281 Compare January 7, 2026 10:16
@Battambang Battambang requested a review from a team as a code owner January 7, 2026 10:16
@github-actions github-actions bot added size-S and removed size-XS labels Jan 7, 2026
GeorgeGkas
GeorgeGkas previously approved these changes Jan 7, 2026
View reviewed changes
@Battambang Battambang force-pushed the gas-fees-sponsored2 branch from b0ab281 to 49bf386 Compare January 7, 2026 11:20
@Battambang Battambang enabled auto-merge January 7, 2026 11:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade, SmokeConfirmationsRedesigned, SmokeStake
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

The PR contains two UI-related changes:

  1. QuoteDetailsCard.tsx (Bridge): A minor change adding iconName: IconName.Info to a tooltip configuration. This is a purely cosmetic change affecting the Bridge quote details card. The component is used in Bridge views and Perps quote details.

  2. gas-fee-details-row.tsx (Confirmations): A more substantial change that:

    • Adds network configuration lookup to get the native token symbol
    • Modifies the tooltip text logic for sponsored gas fees to show a different message using bridge.network_fee_info_content_sponsored string
    • This component is used across multiple confirmation flows: staking (deposit, withdrawal, claim), approve, contract deployment, contract interaction, transfer, and transaction batch

The changes are UI-focused and don't modify core transaction logic, but they affect user-facing elements in important flows:

  • Bridge functionality (SmokeTrade) - for the QuoteDetailsCard icon change
  • Confirmations (SmokeConfirmationsRedesigned) - for the gas fee tooltip changes, especially in sponsored gas fee scenarios (there's a specific test gas-fee-tokens-eip-7702-sponsored.spec.ts)
  • Staking (SmokeStake) - since gas-fee-details-row is used in staking confirmation flows

Risk is medium because while the changes are UI-only, they affect important user-facing elements in transaction confirmations and bridge flows.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 7, 2026

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Battambang Battambang changed the title chore: update tooltip message for network fee for gas fees sponsored case in swap quote card chore: update network fee tooltip for gas fees sponsored case Jan 7, 2026
@Battambang Battambang added this pull request to the merge queue Jan 7, 2026
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jan 7, 2026
Merged via the queue into main with commit a4a3c37 Jan 7, 2026
105 checks passed
@Battambang Battambang deleted the gas-fees-sponsored2 branch January 7, 2026 14:52
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jan 7, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@GeorgeGkas GeorgeGkas GeorgeGkas approved these changes

Assignees

No one assigned

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-S skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-network-enablement

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Battambang @pedronfigueiredo @GeorgeGkas @metamaskbot