Skip to content

feat(card): add Veriff status verification screen#24246

Merged
Brunonascdev merged 7 commits intomainfrom
feat/mm-card-onboarding-veriff-verification
Jan 6, 2026
Merged

feat(card): add Veriff status verification screen#24246
Brunonascdev merged 7 commits intomainfrom
feat/mm-card-onboarding-veriff-verification

Conversation

@Brunonascdev
Copy link
Copy Markdown
Contributor

@Brunonascdev Brunonascdev commented Jan 5, 2026

Description

This PR introduces an intermediate Verification screen in the Card onboarding flow, placed between the Veriff webview and the Personal Details screen.
The main motivation is to correctly handle Veriff KYC outcomes before allowing the user to proceed. Previously, users were always redirected to the next step regardless of the verification result, which could lead to invalid states and confusing UX.

Changelog

CHANGELOG entry: Added a verification step to the Card onboarding flow to validate Veriff KYC results before proceeding.

Related issues

Fixes:

Manual testing steps

Feature: Card onboarding Veriff verification handling

  Scenario: User successfully completes Veriff KYC
    Given the user is in the Card onboarding flow
    And the user completes the Veriff verification
    And Veriff returns a successful KYC response
    When the verification check is performed
    Then the user is redirected to the Personal Details screen

  Scenario: User fails Veriff KYC
    Given the user is in the Card onboarding flow
    And the user completes the Veriff verification
    And Veriff returns a failed or rejected KYC response
    When the verification check is performed
    Then the user is shown the verification error screen
    And the user is prevented from continuing the onboarding flow

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Introduces a dedicated Veriff KYC verification step and rewires onboarding navigation accordingly.

  • Adds VerifyingVeriffKYC screen that polls useUserRegistrationStatus and resets stack to PERSONAL_DETAILS on VERIFIED or KYC_FAILED on REJECTED; tracks metrics and adds i18n strings
  • KYCWebview now StackActions.replaces to CARD.ONBOARDING.VERIFYING_VERIFF_KYC
  • Updates OnboardingNavigator: replaces ValidatingKYC with VerifyingVeriffKYC, adds new route constants, reorders screens, and changes initial-route logic (PENDING with firstName -> VERIFYING_VERIFF_KYC; VERIFIED without countryOfNationality -> PERSONAL_DETAILS else address checks -> PHYSICAL_ADDRESS/COMPLETE)
  • VerifyingRegistration: continue now replaces to CARD.ONBOARDING.ROOTCOMPLETE; auto-replaces to KYC_FAILED when rejected; refines header/actions and copy
  • PhysicalAddress: after successful registration, resets to Routes.CARD.VERIFYING_REGISTRATION
  • Updates metrics (CardScreens.VERIFYING_VERIFF_KYC), route names, and en locale strings; removes ValidatingKYC test and adds comprehensive tests for new flows

Written by Cursor Bugbot for commit c5f051a. This will update automatically on new commits. Configure here.

@Brunonascdev Brunonascdev self-assigned this Jan 5, 2026
@Brunonascdev Brunonascdev requested a review from a team as a code owner January 5, 2026 18:37
@Brunonascdev Brunonascdev added the team-card Card Team label Jan 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeCard
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

The changes are entirely focused on the Card onboarding flow within the app/components/UI/Card/ directory. The modifications include:

  1. New VerifyingVeriffKYC component: A new screen for polling KYC verification status after Veriff identity verification
  2. Navigation flow updates: Changes to how users navigate through the Card onboarding process (KYCWebview → VerifyingVeriffKYC → PersonalDetails, and PhysicalAddress → VerifyingRegistration)
  3. Route renaming: VALIDATING_KYC renamed to VERIFYING_VERIFF_KYC
  4. UI updates in VerifyingRegistration: Changed from ActivityIndicator to Image, added new navigation to KYC_FAILED for rejected state
  5. Localization updates: New strings for verifying_veriff_kyc screen and minor text change for signup button
  6. Comprehensive unit tests: All changes include corresponding test updates

The changes are well-isolated to the Card feature with no impact on:

  • Core wallet functionality
  • Engine or Controllers
  • Other features like swaps, staking, accounts, etc.
  • Critical infrastructure

Only the SmokeCard tag is needed as this is a Card-specific feature change with no cross-feature dependencies.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 6, 2026

@Brunonascdev Brunonascdev added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit 68a666d Jan 6, 2026
91 of 92 checks passed
@Brunonascdev Brunonascdev deleted the feat/mm-card-onboarding-veriff-verification branch January 6, 2026 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XL team-card Card Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants