Skip to content

chore: move network icon to the left in network filter in send flow#24202

Merged
vinnyhoward merged 1 commit intomainfrom
chore-mdp-303-send-flow-asset-selection
Jan 6, 2026
Merged

chore: move network icon to the left in network filter in send flow#24202
vinnyhoward merged 1 commit intomainfrom
chore-mdp-303-send-flow-asset-selection

Conversation

@vinnyhoward
Copy link
Copy Markdown
Contributor

@vinnyhoward vinnyhoward commented Dec 19, 2025

Description

Move network icon to the left in network filter in send flow

Changelog

CHANGELOG entry:null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MDP-303

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

before after
before after

Before

~

After

~

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Reorders NetworkFilterTab to place the network avatar before the label, updating spacing to mr-2.

  • UI/Layout
    • In app/components/Views/confirmations/components/network-filter/network-filter.tsx:
      • NetworkFilterTab: Moves the network Avatar before the text label and updates spacing from ml-2 to mr-2 to align the icon on the left of the label.

Written by Cursor Bugbot for commit 03e8a7d. This will update automatically on new commits. Configure here.

@vinnyhoward vinnyhoward requested a review from a team as a code owner December 19, 2025 18:48
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Dec 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmationsRedesigned
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

The change is a purely cosmetic UI modification in the NetworkFilterTab component within the confirmations flow. The modification:

  1. Moves the network icon from after the label text to before the label text
  2. Changes the margin class from ml-2 to mr-2 to maintain proper spacing

This is a visual-only change with no logic, state management, or API changes. The component is used in the Asset selection component within the send flow of confirmations. While the risk is low (purely cosmetic), running SmokeConfirmationsRedesigned tests is prudent since:

  • The component is part of the confirmations UI flow
  • It affects the send/asset selection experience
  • Confirmations are critical for transaction safety

No other tags are needed as this change doesn't affect:

  • Core wallet functionality (SmokeCore)
  • Network switching (SmokeWalletPlatform)
  • Asset management logic (SmokeAssets)
  • Any other functional areas

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@vinnyhoward vinnyhoward added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit 9abfd43 Jan 6, 2026
179 of 181 checks passed
@vinnyhoward vinnyhoward deleted the chore-mdp-303-send-flow-asset-selection branch January 6, 2026 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XS team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants