Skip to content

test: new quality gates#24187

Merged
javiergarciavera merged 9 commits intomainfrom
MMQA-1238-setting-quality-gate-metrics
Jan 7, 2026
Merged

test: new quality gates#24187
javiergarciavera merged 9 commits intomainfrom
MMQA-1238-setting-quality-gate-metrics

Conversation

@javiergarciavera
Copy link
Copy Markdown
Contributor

@javiergarciavera javiergarciavera commented Dec 19, 2025 •
edited by cursor bot
Loading

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adjusts performance expectations and stabilizes balance detection to reduce flaky runs.

  • Raises/adjusts TimerHelper thresholds across performance specs (login, swap, perps, predict, send, onboarding), especially higher Android limits; minor async measure call cleanups
  • Onboarding/account tests now verify SOL visibility or use checkActiveAccount instead of ETH token checks
  • Adds WalletMainScreen.checkActiveAccount(name)
  • Reworks WalletMainScreen.waitForBalanceToStabilize():
    • iOS: skip stability loop; wait once for non-empty, non-$0.00 balance
    • Android: keep polling with improved element re-fetch, sameResultTimeout reduced to 8s
  • Updates Flows.importSRPFlow timer thresholds and prediction modal helpers; uses device-based account selection in perps test

Written by Cursor Bugbot for commit e968405. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 19, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Dec 19, 2025
@javiergarciavera javiergarciavera requested a review from a team as a code owner December 19, 2025 14:40
cursor[bot]
cursor bot reviewed Jan 7, 2026
View reviewed changes
cursor[bot]
cursor bot reviewed Jan 7, 2026
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

All 15 changed files are exclusively in the appwright/ and wdio/ directories, which are separate test frameworks (Playwright-based and WebdriverIO) from Detox. The changes consist of:

  1. Timer threshold adjustments - Most changes simply increase timeout thresholds in performance tests to accommodate slower execution times on certain platforms (especially Android). These are test configuration changes, not app code changes.

  2. Test utility improvements - The wdio/screen-objects/WalletMainScreen.js file adds a new checkActiveAccount() helper method and optimizes the waitForBalanceToStabilize() function with iOS-specific handling for faster element lookups.

  3. No app code modifications - None of the changes affect the actual MetaMask Mobile application code. All modifications are confined to test infrastructure.

Per the guidance: "Changes to wdio/ or appwright/ directories (separate test frameworks) do not require Detox tags - select none unless app code is also changed." Since there are no app code changes, no Detox E2E tests need to be run to validate these changes.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 7, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@javiergarciavera javiergarciavera added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jan 7, 2026
@javiergarciavera javiergarciavera added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 69198c5 Jan 7, 2026
95 of 96 checks passed
@javiergarciavera javiergarciavera deleted the MMQA-1238-setting-quality-gate-metrics branch January 7, 2026 15:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@matallui matallui matallui approved these changes

@christopherferreira9 christopherferreira9 christopherferreira9 approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-M team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@javiergarciavera @matallui @christopherferreira9 @metamaskbot