Skip to content

test: Fix flaky GasFeeToken e2e test via 7702#24161

Merged
jpuri merged 3 commits intomainfrom
fix/gas-fee-token-e2e-flaky
Jan 6, 2026
Merged

test: Fix flaky GasFeeToken e2e test via 7702#24161
jpuri merged 3 commits intomainfrom
fix/gas-fee-token-e2e-flaky

Conversation

@vinistevam
Copy link
Copy Markdown
Contributor

@vinistevam vinistevam commented Dec 18, 2025 •
edited by cursor bot
Loading

Description

This Pr aims to fix the flakiness for e2e/specs/confirmations-redesigned/transactions/gas-fee-tokens-eip-7702.spec.ts.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #24139

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Improves stability of the EIP-7702 gas fee token e2e and re-enables the test.

  • Unskips gas-fee-tokens-eip-7702.spec.ts; adds assertion that Select a token modal is visible before validations
  • Replaces inline attribute access with RowComponents.getNetworkFeeGasFeeTokenSymbolText() to read the selected token symbol
  • Adds getNetworkFeeGasFeeTokenSymbolText() to RowComponents.ts
  • Adds a visibility check in GasFeeTokenModal.checkAmountFiat() before reading attributes

Written by Cursor Bugbot for commit c40a243. This will update automatically on new commits. Configure here.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Dec 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Dec 18, 2025
@vinistevam vinistevam marked this pull request as ready for review December 18, 2025 15:35
@vinistevam vinistevam requested a review from a team as a code owner December 18, 2025 15:35
jpuri
jpuri previously approved these changes Dec 19, 2025
View reviewed changes
@jpuri jpuri enabled auto-merge December 19, 2025 08:31
@pedronfigueiredo pedronfigueiredo force-pushed the fix/gas-fee-token-e2e-flaky branch from b460bf0 to fba83cd Compare January 6, 2026 08:42
@pedronfigueiredo pedronfigueiredo force-pushed the fix/gas-fee-token-e2e-flaky branch from 3ee253e to c40a243 Compare January 6, 2026 10:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmationsRedesigned
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

The changes are entirely within E2E test infrastructure:

  1. e2e/pages/Browser/Confirmations/RowComponents.ts: Added a new helper method getNetworkFeeGasFeeTokenSymbolText() to extract text from the gas fee token symbol element. This is a utility method only used in the gas-fee-tokens-eip-7702.spec.ts test.

  2. e2e/pages/Confirmation/GasFeeTokenModal.ts: Added an assertion to check that the amount fiat element is visible before getting its attributes - this improves test stability.

  3. e2e/specs/confirmations-redesigned/transactions/gas-fee-tokens-eip-7702.spec.ts:

    • Removed .skip from the test (re-enabling a previously skipped test that was causing app crashes on CI)
    • Added an assertion to check modal visibility
    • Refactored to use the new helper method

All changes are scoped to the confirmations redesigned test suite. The test file explicitly uses the SmokeConfirmationsRedesigned tag. No application code is modified, so only the relevant test tag needs to run to verify these E2E test changes work correctly.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 6, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit 71eee92 Jan 6, 2026
94 checks passed
@jpuri jpuri deleted the fix/gas-fee-token-e2e-flaky branch January 6, 2026 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@pnarayanaswamy pnarayanaswamy pnarayanaswamy approved these changes

@jpuri jpuri jpuri left review comments

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable Send native asset Gas Station using EIP-7702

5 participants

@vinistevam @jpuri @pnarayanaswamy @metamaskbot @pedronfigueiredo