Skip to content

fix: cp-7.61.0 insufficient native balance in metamask pay#23873

Merged
matthewwalsh0 merged 3 commits into
mainfrom
fix/metamask-pay-insufficient-native
Dec 10, 2025
Merged

fix: cp-7.61.0 insufficient native balance in metamask pay#23873
matthewwalsh0 merged 3 commits into
mainfrom
fix/metamask-pay-insufficient-native

Conversation

@matthewwalsh0

@matthewwalsh0 matthewwalsh0 commented Dec 10, 2025 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Member

Description

Ensure Relay deposit transactions created by Perps and Predict deposits have sufficient and consistent gas limits.

Changelog

CHANGELOG entry: Prevent insufficient native balance errors in Perps and Predict deposits

Related issues

Fixes: #23563 #23699

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Enhances MetaMask Pay metrics with fallback chain/token properties, maps relayDeposit to analytics type, enables gas estimate actions in pay messenger, adds tests, and bumps controller dependencies.

  • Metrics (MetaMask Pay)
    • Add fallback properties from transactionMeta.metamaskPay (sets mm_pay, mm_pay_chain_selected, mm_pay_token_selected via TokensController).
    • Set polymarket_account_created for predictDeposit based on nested tx data.
    • New helpers: addFallbackProperties, getTokenSymbol.
  • Analytics Mapping
    • Map TransactionType.relayDeposit to transaction_type value relay_deposit in utils.ts.
  • Messaging
    • Allow TransactionPayController messenger to call TransactionController:estimateGas and :estimateGasBatch.
  • PredictController
    • Type fix: cast gas estimate gas as Hex in beforeSign.
  • Tests
    • Add unit tests covering fallback properties (with/without token symbol).
  • Dependencies
    • Bump @metamask/transaction-controller to 62.6.0, @metamask/transaction-pay-controller to 10.5.0, and bridge-related packages to 64.1.0.

Written by Cursor Bugbot for commit 2057fc5. This will update automatically on new commits. Configure here.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Dec 10, 2025
@matthewwalsh0 matthewwalsh0 force-pushed the fix/metamask-pay-insufficient-native branch from cb53840 to 1355f23 Compare December 10, 2025 16:27
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review December 10, 2025 16:27
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners December 10, 2025 16:27
@socket-security

socket-security Bot commented Dec 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​transaction-pay-controller@​10.4.0 ⏵ 10.5.079 +110079 +197 +1100
Updatednpm/​@​metamask/​transaction-controller@​62.5.0 ⏵ 62.6.09610081 +198 +1100

View full report

@socket-security

socket-security Bot commented Dec 10, 2025 •
edited
Loading

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • npm/@metamask/bridge-controller@64.1.0

View full report

@matthewwalsh0

matthewwalsh0 commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

@SocketSecurity ignore npm/@metamask/bridge-controller@64.1.0

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner December 10, 2025 16:40
@github-actions

github-actions Bot commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions, SmokeConfirmationsRedesigned, SmokeTrade, SmokeAnalytics
  • Risk Level: medium
  • AI Confidence: 78%
click to see 🤖 AI reasoning details

The changes involve:

  1. PredictController.ts: Minor type casting fix for gas estimate return value. This is a low-risk TypeScript type safety improvement that warrants SmokePredictions testing.

  2. metamask-pay.ts/test.ts: Added fallback properties (mm_pay, mm_pay_chain_selected, mm_pay_token_selected) for MetaMask Pay transaction metrics. This affects transaction analytics tracking, warranting SmokeAnalytics and SmokeConfirmationsRedesigned tests.

  3. utils.ts: Added relayDeposit transaction type handling in getTransactionTypeValue. This is used for transaction type analytics/logging.

  4. transaction-pay-controller-messenger.ts: Added TransactionController:estimateGas and TransactionController:estimateGasBatch to the messenger's allowed actions list. This enables the transaction-pay-controller to call gas estimation methods.

  5. Package upgrades:

    • @metamask/transaction-controller: 62.5.0 → 62.6.0
    • @metamask/transaction-pay-controller: 10.4.0 → 10.5.0

The transaction-pay-controller is heavily used in confirmations flows and trading functionality (bridge, swaps). The changes are mostly additive (new analytics properties, new messenger actions, new transaction type) rather than modifying existing behavior, which lowers the risk. However, package upgrades to core controllers warrant testing the main flows that use them.

Selected SmokeTrade because the transaction-pay-controller is integral to trading/bridge flows. SmokeConfirmationsRedesigned covers the confirmation UI that uses transaction pay data.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Dec 10, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@matthewwalsh0 matthewwalsh0 added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Dec 10, 2025
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit ad74b59 Dec 10, 2025
164 of 168 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/metamask-pay-insufficient-native branch December 10, 2025 18:44
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2025
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matallui matallui matallui approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-M skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Better handle transactions that are pending forever

5 participants

@matthewwalsh0 @matallui @OGPoyraz @tommasini @metamaskbot