Skip to content

fix: MUL-1331 modify android manifest file for correct BLE location permission.#23759

Merged
angelcheung22 merged 5 commits intomainfrom
fix/MUL-1331-android-location-permission
Jan 7, 2026
Merged

fix: MUL-1331 modify android manifest file for correct BLE location permission.#23759
angelcheung22 merged 5 commits intomainfrom
fix/MUL-1331-android-location-permission

Conversation

@dawnseeker8
Copy link
Copy Markdown
Contributor

@dawnseeker8 dawnseeker8 commented Dec 8, 2025

our current BLE permission is wrong based on https://consensyssoftware.atlassian.net/browse/MUL-1331 record.
This PR will update the manifest.yml file to correct the wrong setting in BLE permisison.

Description

Changelog

CHANGELOG entry: Modify the android manifest so that android 12+ will never ask for location permission.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1331

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adjusts BLE-related permissions to avoid unnecessary location prompts on Android 12+.

  • In android/app/src/main/AndroidManifest.xml, restricts ACCESS_FINE_LOCATION with android:maxSdkVersion="30" (pre-Android 12 only)
  • Adds android:usesPermissionFlags="neverForLocation" to BLUETOOTH_SCAN (Android 12+)

Written by Cursor Bugbot for commit 7eb729d. This will update automatically on new commits. Configure here.

…ons and adjust Bluetooth_SCAN permission flags for improved compatibility with Android 12 and above.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

The changes in AndroidManifest.xml are purely Android platform permission configuration changes for Bluetooth functionality:

  1. ACCESS_FINE_LOCATION: Added android:maxSdkVersion="30" to limit this permission to Android 11 and below
  2. BLUETOOTH_SCAN: Added android:usesPermissionFlags="neverForLocation" to indicate Bluetooth scanning won't be used for location derivation

These changes:

  • Are configuration-only (no application logic changes)
  • Follow Android 12+ best practices for Bluetooth permissions
  • Improve user privacy by reducing unnecessary location permission requests
  • Affect Ledger hardware wallet Bluetooth connectivity, which cannot be tested in E2E automation (requires physical hardware)
  • Have no corresponding E2E tests in the test suite (confirmed via grep search)

The changes are low-risk permission optimizations that don't affect any testable user flows in the E2E test suite. Hardware wallet functionality via Bluetooth requires physical devices and cannot be validated through automated E2E tests.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 7, 2026

@angelcheung22 angelcheung22 added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit ddd333c Jan 7, 2026
74 checks passed
@angelcheung22 angelcheung22 deleted the fix/MUL-1331-android-location-permission branch January 7, 2026 04:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XS team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants