feat: convert choosePassword code from javascript to typescript.#23483
Merged
feat: convert choosePassword code from javascript to typescript.#23483
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…or FoxRiveLoaderAnimation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23483 +/- ##
==========================================
+ Coverage 79.11% 79.30% +0.19%
==========================================
Files 4053 4056 +3
Lines 106578 106749 +171
Branches 21592 21672 +80
==========================================
+ Hits 84321 84662 +341
+ Misses 16379 16197 -182
- Partials 5878 5890 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ieow
reviewed
Jan 6, 2026
| }); | ||
|
|
||
| ( | ||
| navigation as unknown as { |
ieow
reviewed
Jan 6, 2026
| if (loading) { | ||
| // update navigationOptions | ||
| ( | ||
| navigation as unknown as { setParams: (params: object) => void } |
ieow
reviewed
Jan 6, 2026
| } | ||
| }, [loading, navigation, EmptyHeaderLeft]); | ||
|
|
||
| useEffect( |
Contributor
There was a problem hiding this comment.
Add comment for the unmounting useEffect
Move the unmouting to line 659 as passwordSetupAttemptTraceCtx is being used there
ieow
reviewed
Jan 6, 2026
| useEffect(() => { | ||
| if (error && !keyringControllerPasswordSet.current) { | ||
| if (mounted.current) { | ||
| captureException(new Error(error)); |
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsFallback: AI analysis did not complete successfully. Running all tests. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-12-01.at.8.56.02.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Migrates ChoosePassword to a TypeScript functional component with extracted styles/types, updates tests, and tweaks the password visibility toggle to a pressable accessory.
Views/ChoosePasswordfrom class-based JS (index.js) to a TypeScript functional component (index.tsx) using React hooks,useNavigation/useRoute, and Redux hooks.ChoosePassword.styles.tsand route/types toChoosePassword.types.ts.TouchableOpacityaround the eye icon.index.test.tsxto target the new TSX component, hooks-based navigation/metrics, and mocks; refreshes snapshot to reflect the pressable eye icon and loading animation.Written by Cursor Bugbot for commit 47a5e0c. Configure here.