Skip to content

fix: content capitalization and punctuation fixes#23296

Merged
georgewrmarshall merged 11 commits intomainfrom
casing-and-punctuation-patch-1
Jan 16, 2026
Merged

fix: content capitalization and punctuation fixes#23296
georgewrmarshall merged 11 commits intomainfrom
casing-and-punctuation-patch-1

Conversation

@coreyjanssen
Copy link
Copy Markdown
Contributor

@coreyjanssen coreyjanssen commented Nov 26, 2025 •
edited by cursor bot
Loading

Description

This PR corrects content design issues including:

  1. Aligning UI copy with sentence case standards (e.g., "Smart Account" → "smart account", "QR Code" → "QR code")
  2. Fixing punctuation inconsistencies (removing excessive exclamation marks, correcting periods)
  3. Updating outdated terminology (e.g., "Predict" → "Predictions")
  4. Standardizing terminology across the app (e.g., "Chain ID" usage)

These are copy-only changes with no functional logic modifications. All affected tests and snapshots have been updated to match the new copy.

Changelog

CHANGELOG entry: Fixed UI copy casing to align with sentence case standards and corrected punctuation inconsistencies

Related issues

Fixes: (Internal content design review)

Manual testing steps

```gherkin
Feature: UI copy consistency

Scenario: user views updated UI text throughout the app
Given the app is running with updated copy changes

When user navigates through various screens (Settings, Account Actions, Perps, etc.)
Then all UI text should display with consistent sentence case and proper punctuation
And terminology should be standardized (e.g., "Predictions" instead of "Predict")

```

Screenshots/Recordings

N/A - Text-only changes visible throughout the app UI

Before

Various inconsistent casing (e.g., "Smart Account", "QR Code", excessive punctuation)

After

Consistent sentence case (e.g., "smart account", "QR code", streamlined punctuation)

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Aligns UI text to sentence case, streamlines punctuation, and standardizes terminology across multiple surfaces; no functional logic changes.

  • Updates labels and headings (e.g., "Smart account", "QR code", "WalletConnect sessions", "IPFS gateway", "Select your region/quote") across Perps, Settings, WalletConnect, Browser, Asset views, and more
  • Refines copy in confirmations, notifications, and error/empty states (e.g., "Verify third-party details", "You have no transactions", polished order/NFT notifications)
  • Replaces "dapp" with "site" in AccountApproval text; improves phrasing in Ramp/Deposit fields (e.g., "Postal code")
  • Improves accessibility labels and localization in Ramp Settings (ActivationKeys.tsx) and related tests
  • Adjusts Predict docs/tests to "Prediction markets" naming
  • Updates unit/e2e tests and snapshots to match new copy (Perps, Ramp Aggregator, RegionSelector, Quotes, AccountActions, Import flows, Settings, WalletConnect, Predict)

Written by Cursor Bugbot for commit 217a498. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 26, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Nov 26, 2025
cursor[bot]
cursor bot reviewed Nov 26, 2025
View reviewed changes
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent terminology for Predictions feature

The value "Funded Predict account" uses the old terminology "Predict" instead of "Predictions". This is inconsistent with the PR's stated goal of updating "Predict to Predictions" and creates inconsistency across the app. Other similar keys like tx_review_predict_deposit at line 3492 correctly use "Funded predictions", and the main title at line 1779 uses "MetaMask Predictions". This inconsistency will confuse users who see different terminology for the same feature.

locales/languages/en.json#L6929-L6930

metamask-mobile/locales/languages/en.json

Lines 6929 to 6930 in 0cf8155

"predict_claim": "Claimed winnings",
"predict_deposit": "Funded Predict account",

Fix in Cursor Fix in Web

@georgewrmarshall georgewrmarshall force-pushed the casing-and-punctuation-patch-1 branch from 0cf8155 to 35aabdb Compare December 18, 2025 01:59
cursor[bot]
cursor bot reviewed Dec 18, 2025
View reviewed changes
@georgewrmarshall georgewrmarshall force-pushed the casing-and-punctuation-patch-1 branch from 35aabdb to daf3bf1 Compare January 13, 2026 21:18
@georgewrmarshall georgewrmarshall requested review from a team as code owners January 13, 2026 21:18
@github-actions github-actions bot added size-M and removed size-L labels Jan 13, 2026
@georgewrmarshall georgewrmarshall marked this pull request as draft January 14, 2026 17:39
@georgewrmarshall georgewrmarshall force-pushed the casing-and-punctuation-patch-1 branch from 143a175 to b92b4ef Compare January 14, 2026 22:09
@georgewrmarshall georgewrmarshall changed the title Capitalization and punctuation fixes fix: capitalization and punctuation fixes Jan 15, 2026
@georgewrmarshall georgewrmarshall changed the title fix: capitalization and punctuation fixes fix: content capitalization and punctuation fixes Jan 15, 2026
@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Mobile and removed team-design-system All issues relating to design system in Mobile labels Jan 15, 2026
@georgewrmarshall georgewrmarshall marked this pull request as ready for review January 15, 2026 18:09
@georgewrmarshall georgewrmarshall requested review from a team as code owners January 15, 2026 18:09
coreyjanssen
coreyjanssen commented Jan 15, 2026
View reviewed changes
coreyjanssen
coreyjanssen commented Jan 15, 2026
View reviewed changes
coreyjanssen
coreyjanssen commented Jan 15, 2026
View reviewed changes
coreyjanssen
coreyjanssen commented Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@coreyjanssen coreyjanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments for you @georgewrmarshall, overall great!

@georgewrmarshall georgewrmarshall requested a review from a team as a code owner January 15, 2026 19:25
@georgewrmarshall georgewrmarshall force-pushed the casing-and-punctuation-patch-1 branch from bcfdf61 to 217a498 Compare January 15, 2026 20:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 15, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

This PR is a comprehensive copy/text/localization update that makes no functional changes to the application. The changes include:

  1. Localization file updates (en.json): Extensive text changes including capitalization fixes (e.g., "Smart Account" → "Smart account"), terminology standardization (e.g., "dapp" → "site", "PnL" → "P&L"), grammar improvements, and punctuation fixes. These are purely cosmetic changes to user-facing text.

  2. Unit test updates: All test file changes are updating expected text strings to match the new localization values. No test logic changes.

  3. Snapshot updates: All snapshot changes reflect the new text strings from the localization file.

  4. E2E test changes:

    • send-erc20-with-dapp.spec.ts: Only a comment change (not affecting test execution)
    • predict-api-down.spec.ts: Only the test description string changed ("Prediction Markets" → "Prediction markets")

  5. Critical file (create-push-message.test.ts): Only updates test assertions to match new notification text - no functional changes.

  6. Minor code change (ActivationKeys.tsx): Updates accessibility labels to use localized strings - a minor improvement with no functional impact.

Since all changes are text/copy updates with no functional code changes, no business logic modifications, and no changes to user flows or application behavior, running E2E tests would not provide additional validation value. The unit tests and snapshots have already been updated to verify the text changes are correctly applied.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 15, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgewrmarshall georgewrmarshall removed their request for review January 16, 2026 16:44
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit a511857 Jan 16, 2026
62 checks passed
@georgewrmarshall georgewrmarshall deleted the casing-and-punctuation-patch-1 branch January 16, 2026 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
@metamaskbot metamaskbot added the release-7.63.0 Issue or pull request that will be included in release 7.63.0 label Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@wachunei wachunei wachunei approved these changes

@matallui matallui matallui approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@gambinish gambinish gambinish approved these changes

Assignees

No one assigned

Labels

release-7.63.0 Issue or pull request that will be included in release 7.63.0 size-M team-design-system All issues relating to design system in Mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@coreyjanssen @wachunei @matallui @georgewrmarshall @pedronfigueiredo @vinnyhoward @gambinish @metamaskbot