fix: cp-7.58.0 formatTimeRemaining to correctly display time remaining#21843
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jbblanc
previously approved these changes
Oct 29, 2025
a602e68 to
a87305a
Compare
jbblanc
approved these changes
Oct 29, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now the rewards component that displays the number of time left is incorrectly showing the time left if the hours value returned by
getTimeDifferenceFromNowis 0. (it will only show minutes left in this case) This will happen if the end date of the season versus the current time on the app is X day(s) 0 hours and X minute(s).Changelog
CHANGELOG entry: fix rewards season time remaining
Related issues
Fixes: #21842
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adjust time-remaining formatting to include days/hours/minutes with stricter null conditions and update tests, plus locale checks for rewards date formatting.
formatTimeRemainingto compose output fromdays,hours, andminutes, trim trailing space, and returnnullonly when all are non-positive.formatUtils.test.tsfor newformatTimeRemainingbehavior (e.g., days+minutes, hours-only, minutes-only, large diffs, zero/negative cases, trimming).formatRewardsDate(default and custom locales).getIntlNumberFormatter.Written by Cursor Bugbot for commit a87305a. This will update automatically on new commits. Configure here.