Description

This PR adds support for batch PERPS position estimation in the RewardsController to enable the "close all positions" feature. The backend API (rewards team PR #247) was already deployed with support for accepting perpsContext as either a single object or an array of positions, returning aggregated points and bonus estimates.

Changes:

1. Updated EstimatePointsContextDto type to accept perpsContext as either a single object or an array
2. Enhanced JSDoc documentation to explain batch estimation behavior (aggregated points sum + average bonus)
3. Added minimal unit test coverage for batch PERPS array functionality

The implementation maintains backwards compatibility with existing single-position calls and follows a pass-through architecture (no controller logic changes needed).

Changelog

CHANGELOG entry: support batch points estimation for perps

Related issues

Fixes:

Manual testing steps

Feature: Batch PERPS position rewards estimation

  Scenario: user estimates rewards for closing multiple PERPS positions
    Given user has multiple open PERPS positions
    And rewards feature is enabled
    And user has opted into rewards

    When user requests to close all positions
    Then RewardsController estimates points for all positions in a single batch request
    And backend returns aggregated points estimate (sum of all position points)
    And backend returns average bonus across all positions

Screenshots/Recordings

N/A - Backend/Controller change only, no UI modifications

Before

perpsContext only accepted single object

After

perpsContext accepts single object or array of objects for batch estimation

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Technical Details

Files Modified:

• app/core/Engine/controllers/rewards-controller/types.ts (lines 133-147)
• app/core/Engine/controllers/rewards-controller/RewardsController.ts (lines 1544-1550)
• app/core/Engine/controllers/rewards-controller/RewardsController.test.ts (lines 820-850)

Type Changes:

// Before
perpsContext?: EstimatePerpsContextDto;

// After
perpsContext?: EstimatePerpsContextDto | EstimatePerpsContextDto[];

Test Coverage:

• Added test: "estimates points for batch PERPS positions with array"
• All existing tests pass (4/4 estimatePoints tests passing)
• No regressions introduced