chore: Ensure Engine.state has complete engine state#21482
Conversation
3ab5330 to
697685a
Compare
|
Calling those lines "duplicate code" is ridiculous. I've skipped Sonar for this PR to suppress that blocker. |
697685a to
de86e5f
Compare
|
de86e5f to
d1d68b7
Compare
The getter `Engine.state` was missing the state of some controllers. It has been updated to include everything, and a unit test has been added to ensure we don't forget to add state to this again in the future.
d1d68b7 to
3b2d0d0
Compare
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThe changes modify the core Engine.ts file to add While this is a critical file (Engine.ts), the changes are relatively low-risk because:
I recommend running:
The changes don't directly affect swaps, staking, assets, notifications, or other specific features, so those tags are not necessary. |
|




Description
The getter
Engine.statewas missing the state of some controllers. It has been updated to include everything, and a unit test has been added to ensure we don't forget to add state to this again in the future.There is no known user impact, we don't rely on this state to be present right now. This was done to let us use this as a replacement for
Engine.datamodellater on.Changelog
CHANGELOG entry: null
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Ensures the
Engine.stategetter exposes a complete engine state and guards access before initialization.GatorPermissionsControllerandSnapsRegistrytoEngine.stateinEngine.tsEngine.test.tsto assert:Engine.statebefore initialization throws an errorEngine.stateincludes all controllers that have non-emptystateWritten by Cursor Bugbot for commit f488d7a. This will update automatically on new commits. Configure here.