Skip to content

chore(runway): cherry-pick fix: cp-7.57.0 app bricks on asset sorting#21263

Merged
juanmigdr merged 1 commit into
release/7.57.0from
runway-cherry-pick-7.57.0-1760608154
Oct 16, 2025
Merged

chore(runway): cherry-pick fix: cp-7.57.0 app bricks on asset sorting#21263
juanmigdr merged 1 commit into
release/7.57.0from
runway-cherry-pick-7.57.0-1760608154

Conversation

@runway-github

@runway-github runway-github Bot commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

Description

From the Home token list, if the user sets a sort/filter such as
Descending by balance, the app crashes to the generic error screen on
next render and becomes unrecoverable. Force-quitting and relaunching
does not help; only uninstall + reinstall clears the state. The crash
message indicates the Wallet view throws on localeCompare of null.

Changelog

CHANGELOG entry:

Related issues

Fixes: #21218

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Extends sortAssets to move null values to the end (like undefined) and adds tests covering null handling for alphaNumeric sorting.

  • Utilities:
    • Update app/components/UI/Tokens/util/sortAssets.ts to treat null values like undefined by moving them to the end regardless of sort order.
  • Tests:
    • Add tests in app/components/UI/Tokens/util/sortAssets.test.ts verifying alphaNumeric sorting handles null in both ascending and descending orders.

Written by Cursor Bugbot for commit f93b4c5. This will update automatically on new commits. Configure here.

26ca44f

…#21256)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
From the Home token list, if the user sets a sort/filter such as
Descending by balance, the app crashes to the generic error screen on
next render and becomes unrecoverable. Force-quitting and relaunching
does not help; only uninstall + reinstall clears the state. The crash
message indicates the Wallet view throws on `localeCompare` of `null`.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes: #21218

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

### **After**

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Update `sortAssets` to move nullish values to the end during sorting
and add tests for null handling in alphaNumeric asc/desc cases.
> 
> - **Utils**:
> - Update `app/components/UI/Tokens/util/sortAssets.ts` to treat `null`
like `undefined` (`aValue == null` / `bValue == null`) so nullish values
are always placed at the end regardless of order.
> - **Tests**:
> - Add tests in `app/components/UI/Tokens/util/sortAssets.test.ts` to
verify alphaNumeric sorting with `null` names in both ascending and
descending orders.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
420abbc. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner October 16, 2025 09:49
@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Oct 16, 2025
@sonarqubecloud

Copy link
Copy Markdown

@juanmigdr juanmigdr merged commit 7ff8736 into release/7.57.0 Oct 16, 2025
107 of 110 checks passed
@juanmigdr juanmigdr deleted the runway-cherry-pick-7.57.0-1760608154 branch October 16, 2025 10:26
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 16, 2025
@metamaskbot metamaskbot added the release-7.57.0 Issue or pull request that will be included in release 7.57.0 label Oct 16, 2025
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.57.0 on PR, as PR was cherry-picked in branch 7.57.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.57.0 Issue or pull request that will be included in release 7.57.0 size-S team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants