fix: choosePassword description update for ios and social-login user. cp-7.57.0#21258
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
9 tasks
himanshuchawla009
approved these changes
Oct 16, 2025
Collaborator
|
No release label on PR. Adding release label release-7.57.0 on PR, as PR was added to branch 7.57.0 when release was cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes: iOS “Create Password” screen shows social‑login description incorrectly #21192
Changelog
CHANGELOG entry: choosePassword description update for ios and social-login user
Related issues
Fixes: choosePassword description update for ios and social-login user
#21022
Manual testing steps
Screenshots/Recordings
Before
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding?node-id=12501-102542&m=dev
After
Screen.Recording.2025-10-16.at.12.15.12.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Makes OAuth success description on ChoosePassword platform-specific (iOS vs Android) and adds corresponding test and i18n string.
app/components/Views/ChoosePassword/index.js):choose_password.description_social_login_update_ios(single sentence).choose_password.description_social_login_updatewith separate warning text (description_social_login_update_bold).app/components/Views/ChoosePassword/index.test.tsx):Platform; add iOS-specific description test to validate new copy whenoauthLoginSuccessis true on iOS.locales/languages/en.json):choose_password.description_social_login_update_iosstring.Written by Cursor Bugbot for commit 89acab5. This will update automatically on new commits. Configure here.