fix(deposit): remove unresponsive period from keypad cp-7.57.0#21233
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
amitabh94
approved these changes
Oct 15, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This pull request simplifies the
BuildQuotecomponent that rendered an unresponsive period button by removing unnecessary props from theKeypadcomponent and updates the related test snapshots to reflect these changes. The most significant updates are focused on cleaning up the UI code and ensuring the test outputs are consistent with the new implementation.Component simplification:
Keypadcomponent inBuildQuote.tsxno longer receives extra props such ascurrency,decimals, andperiodButtonProps, and is now only passed the essentialvalueandonChangeprops, removing the unresponsive button.Changelog
CHANGELOG entry: Fixed an unresponsive period button in the Deposit keypad.
Related issues
Fixes: #21234
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-10-15.at.4.25.30.PM.mov
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes the period key by simplifying
Keypadprops inBuildQuote.tsxand updates related snapshots.Keypadusage inapp/components/UI/Ramp/Deposit/Views/BuildQuote/BuildQuote.tsxto onlyvalueandonChange, removingcurrency,decimals, andperiodButtonProps(period key removed).BuildQuote.test.tsx.snapreflecting the absence of the disabled period button and related text nodes.Written by Cursor Bugbot for commit c1163bd. This will update automatically on new commits. Configure here.