Skip to content

fix(deposit): remove unresponsive period from keypad cp-7.57.0#21233

Merged
wachunei merged 1 commit into
mainfrom
fix/deposit-keypad-period
Oct 15, 2025
Merged

fix(deposit): remove unresponsive period from keypad cp-7.57.0#21233
wachunei merged 1 commit into
mainfrom
fix/deposit-keypad-period

Conversation

@wachunei

@wachunei wachunei commented Oct 15, 2025

Copy link
Copy Markdown
Member

Description

This pull request simplifies the BuildQuote component that rendered an unresponsive period button by removing unnecessary props from the Keypad component and updates the related test snapshots to reflect these changes. The most significant updates are focused on cleaning up the UI code and ensuring the test outputs are consistent with the new implementation.

Component simplification:

  • The Keypad component in BuildQuote.tsx no longer receives extra props such as currency, decimals, and periodButtonProps, and is now only passed the essential value and onChange props, removing the unresponsive button.

Changelog

CHANGELOG entry: Fixed an unresponsive period button in the Deposit keypad.

Related issues

Fixes: #21234

Manual testing steps

Feature: Deposit

  Scenario: user interacts with the keypad
    Given the Deposit build quote page

    When user interacts with the keypad
    Then the period button is not visible

Screenshots/Recordings

Before

Screen.Recording.2025-10-15.at.4.25.30.PM.mov

After

no_period

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes the period key by simplifying Keypad props in BuildQuote.tsx and updates related snapshots.

  • UI:
    • Simplifies Keypad usage in app/components/UI/Ramp/Deposit/Views/BuildQuote/BuildQuote.tsx to only value and onChange, removing currency, decimals, and periodButtonProps (period key removed).
  • Tests:
    • Updates snapshots in BuildQuote.test.tsx.snap reflecting the absence of the disabled period button and related text nodes.

Written by Cursor Bugbot for commit c1163bd. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Oct 15, 2025
@wachunei wachunei changed the title fix(deposit): remove unresponsive period from keypad fix(deposit): remove unresponsive period from keypad cp-7.57.0 Oct 15, 2025
@wachunei

Copy link
Copy Markdown
Member Author

I have read the CLA Document and I hereby sign the CLA

@wachunei wachunei marked this pull request as ready for review October 15, 2025 19:57
@wachunei wachunei requested a review from a team as a code owner October 15, 2025 19:57
@sonarqubecloud

Copy link
Copy Markdown

@wachunei wachunei enabled auto-merge October 15, 2025 20:14
@wachunei wachunei added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit 9b9b624 Oct 15, 2025
110 of 111 checks passed
@wachunei wachunei deleted the fix/deposit-keypad-period branch October 15, 2025 20:37
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2025
@metamaskbot metamaskbot added the release-7.58.0 Issue or pull request that will be included in release 7.58.0 label Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.58.0 Issue or pull request that will be included in release 7.58.0 size-XS team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Decimal button isn't clickable on the keypad on the ramps deposit screen

3 participants