Skip to content

feat: cp-7.57.0 TAT-1883 perps tutorial regressions animations are cut off and ready to trade text and subtext overlap#21220

Merged
Matt561 merged 2 commits into
mainfrom
feat/tat-1883-perps-tutorial-regressions-animations-are-cut-off-and-ready-to-trade-text-and-subtext-overlap
Oct 15, 2025
Merged

feat: cp-7.57.0 TAT-1883 perps tutorial regressions animations are cut off and ready to trade text and subtext overlap#21220
Matt561 merged 2 commits into
mainfrom
feat/tat-1883-perps-tutorial-regressions-animations-are-cut-off-and-ready-to-trade-text-and-subtext-overlap

Conversation

@Matt561

@Matt561 Matt561 commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes recent regressions in the Perps tutorial carousel

Changes:

  • Fixed tutorial animations being cut-off at the bottom
  • Fixed "Ready to trade?" screen title and description text rendering on top of each other
  • Replaced HyperEVM reference with HyperCore

Changelog

CHANGELOG entry: fixed tutorial animations being cut-off at the bottom
CHANGELOG entry: fixed "Ready to trade?" screen title and description text rendering on top of each other
CHANGELOG entry: updated HyperEVM reference with HyperCore

Related issues

Fixes: TAT-1883: Perps Tutorial Regression: Animations are cut-off and ready to trade text and subtext overlap

Manual testing steps

Feature: Perps Tutorial Carousel

  Scenario: Tutorial animations are cut-off at the bottom
    Given user is navigating through the tutorial carousel

    When user views tutorial screens
    Then animations are no longer being cut off at the bottom

  Scenario: "Ready to trade?" screen title and description text overlap
    Given user is eligible for Perps (not geo-blocked) and is on the last tutorial screen

    When user views "Ready to trade?" screen
    Then title and description text aren't rendered on top of each other anymore

Screenshots/Recordings

Before

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Prevents animation cutoff and footer text overlap in the Perps tutorial, and replaces HyperEVM with HyperCore across localized strings.

  • Perps Tutorial UI:
    • PerpsTutorialCarousel.styles.ts: set screenContainer minHeight: '100%' (instead of flex: 1).
    • PerpsTutorialCarousel.tsx: remove image minHeight, and reposition footerTextContainer within the content view to avoid overlap.
  • i18n:
    • Replace HyperEVM with HyperCore in perps.tutorial.ready_to_trade.footer_text and tooltip.perps_deposit.transaction_fee across locales (de, el, en, es, fr, hi, id, ja, ko, pt, ru, tl, tr, vi, zh).

Written by Cursor Bugbot for commit 6b75996. This will update automatically on new commits. Configure here.

@Matt561 Matt561 requested a review from a team as a code owner October 15, 2025 18:14
@Matt561 Matt561 added No QA Needed Apply this label when your PR does not need any QA effort. team-perps Perps team labels Oct 15, 2025
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud

Copy link
Copy Markdown

@Matt561 Matt561 enabled auto-merge October 15, 2025 18:41
@Matt561 Matt561 added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit ca273b7 Oct 15, 2025
117 of 118 checks passed
@Matt561 Matt561 deleted the feat/tat-1883-perps-tutorial-regressions-animations-are-cut-off-and-ready-to-trade-text-and-subtext-overlap branch October 15, 2025 19:01
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2025
@metamaskbot metamaskbot added the release-7.58.0 Issue or pull request that will be included in release 7.58.0 label Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.58.0 Issue or pull request that will be included in release 7.58.0 size-S team-earn team-perps Perps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants