Closed
Conversation
wachunei
reviewed
Jan 19, 2021
wachunei
reviewed
Jan 19, 2021
wachunei
reviewed
Jan 19, 2021
1f60f52 to
43dd367
Compare
43dd367 to
2e85699
Compare
Contributor
Author
|
closing in favour of: #2191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes it so you can't double click in Settings (this component might be useful elsewhere?)
Before:
(you could double click on a setting and it'll push the same thing to the navigation stack twice)
Screen.record.from.2021-01-18.18.43.59.mp4
After:
(accidentally double clicking only pushes one thing to the stack)
Screen.record.from.2021-01-18.18.44.34.mp4
Checklist