feat: social login check added in description in create password. cp-7.57.0#21187
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
himanshuchawla009
approved these changes
Oct 15, 2025
Collaborator
|
Missing release label release-7.57.0 on PR. Adding release label release-7.57.0 on PR and removing other release labels(release-7.58.0), as PR was cherry-picked in branch 7.57.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes: #21192
Changelog
CHANGELOG entry: social login check added in description in create password
Related issues
Fixes: social login check added in description in create password
Manual testing steps
Screenshots/Recordings
Before
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding?node-id=12501-102542&m=dev
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Show iOS-specific OAuth description only when OAuth login succeeded; add tests validating platform-specific text rendering.
app/components/Views/ChoosePassword/index.js):Platform.OS === 'ios' && getOauth2LoginSuccess()so the iOS copy shows only after successful OAuth login; otherwise use the generic description. Android warning copy unchanged.app/components/Views/ChoosePassword/index.test.tsx):Platformand add tests to assert correct description text for iOS vs Android whenoauthLoginSuccessis true.Written by Cursor Bugbot for commit 2cbd2e5. This will update automatically on new commits. Configure here.