fix: Broken deposit monitor toasts cp-7.57.0#21165
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dylanbutler1
previously approved these changes
Oct 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
… to est. time 1 min
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Matt561
previously approved these changes
Oct 15, 2025
Matt561
left a comment
Contributor
There was a problem hiding this comment.
Tests well on iOS simulator. 👍
Member
Author
|
Adding recordings from latest commits: Screen.Recording.2025-10-15.at.12.20.15.PM.movScreen.Recording.2025-10-15.at.12.21.11.PM.mov |
|
Matt561
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression to Deposit toasts not firing. Also removes time estimation from non arb.USDC deposits as they weren't as accurate as they would seem, since they require multiple bridge txns.
Changelog
CHANGELOG entry: Fix regression to perps deposit toasts
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Screen.Recording.2025-10-14.at.2.27.02.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a deposit status hook that drives perps deposit toasts (in-progress/success/error) with balance monitoring, wires it into the stream bridge, and defines Arbitrum chainId hex.
usePerpsDepositStatusto subscribe toTransactionControllerupdates, show in‑progress toasts (0s forarb.USDC, 60s otherwise), detect success via liveavailableBalanceincrease, and surface errors with cleanup.usePerpsDepositStatusfromcomponents/UI/Perps/components/PerpsStreamBridge.tsxalongside withdrawal status.hooks/usePerpsDepositStatus.test.tscovering transaction handling, balance monitoring, controller error handling, and cleanup.ARBITRUM_MAINNET_CHAIN_ID_HEXinconstants/hyperLiquidConfig.ts.Written by Cursor Bugbot for commit 9e83bce. This will update automatically on new commits. Configure here.