Description

This PR fixes critical button responsiveness issues in ScrollView and BottomSheet contexts by refactoring gesture handling and removing deprecated press coordination logic across the component library.

Problem:

• Buttons were unresponsive in ScrollView contexts on Android due to TouchableOpacity conflicts
• Buttons in BottomSheet components (like "Got it", "Add funds", "Withdraw") had gesture handler conflicts with BottomSheet pan gestures
• The existing useCoordinatedPress hook was causing double-firing issues and race conditions with accessibility features

Solution:

1. Gesture priority management: Implemented requireExternalGestureToFail() with tight constraints (300ms max duration, 20px max delta) to allow buttons to work alongside BottomSheet gestures
2. Accessibility-aware handling: Implemented exclusive gesture handling - use gesture handler when accessibility is OFF, TouchableOpacity when accessibility is ON/UNKNOWN to prevent race conditions
3. Simplified coordination: Removed deprecated useCoordinatedPress hook and related timestamp-based coordination logic
4. Test environment safety: Added fallback to standard RNTouchableOpacity in test environments

Changelog

CHANGELOG entry: Fixed button responsiveness issues in ScrollView and BottomSheet contexts

Related issues

Fixes: #18704

Manual testing steps

Feature: Button responsiveness in various contexts

  Scenario: user taps buttons in ScrollView contexts
    Given user is viewing buttons within a ScrollView on Android
    When user taps any button
    Then button should respond immediately without delay
    
  Scenario: user taps buttons in BottomSheet modals
    Given user sees a BottomSheet modal with action buttons
    When user taps action buttons (e.g., "Got it", "Add funds")
    Then buttons should respond without conflicting with sheet gestures
    
  Scenario: accessibility users interact with buttons
    Given screen reader is enabled
    When user taps any button
    Then button should respond using TouchableOpacity onPress (not gesture handler)
    And should not experience double-firing or race conditions
    
  Scenario: gesture handling in test environments
    Given app is running in test environment
    When tests interact with buttons
    Then buttons should use standard RNTouchableOpacity behavior

Screenshots/Recordings

Before

After

Technical Changes

Core Components Updated:

• ButtonBase.tsx - Added gesture handler with requireExternalGestureToFail() and tight constraints, accessibility state tracking to prevent double-firing
• ListItemSelect.tsx - Same gesture priority fix and accessibility handling
• ListItemMultiSelect.tsx - Updated gesture handling while preserving iOS checkbox coordination
• PressablePerpsComponent.tsx - Removed useCoordinatedPress hook (already compatible)

Perps Components Updated:

• PerpsTabView.tsx - Removed useCoordinatedPress usage, direct onPress calls
• PerpsCard.tsx - Removed useCoordinatedPress usage, simplified press handling

Key Technical Improvements:

1. Gesture Conflict Resolution: requireExternalGestureToFail() allows BottomSheet pan gestures to take priority when needed, while still detecting taps within tight constraints
2. Accessibility Race Condition Fix: Use null initial state for isAccessibilityEnabled to handle async updates safely; exclusive handling prevents double-firing
3. Test Environment Compatibility: Conditional fallback to standard TouchableOpacity in tests
4. Performance: Removed unnecessary coordination wrapper and timestamp tracking

Implementation Details:

• Gesture handler only fires when isAccessibilityEnabled === false (known OFF state)
• TouchableOpacity onPress only fires when isAccessibilityEnabled !== false (ON or UNKNOWN state)
• Tight gesture constraints: 300ms max duration, 20px max delta, single pointer only
• onEnd lifecycle used (not onStart) to ensure complete gesture detection

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.