Skip to content

fix: align perps activity items with perps activity UI#21097

Merged
baptiste-marchand merged 5 commits into
mainfrom
RWDS-607-align-perps-activity-items-with-perps-activity-ui
Oct 13, 2025
Merged

fix: align perps activity items with perps activity UI#21097
baptiste-marchand merged 5 commits into
mainfrom
RWDS-607-align-perps-activity-items-with-perps-activity-ui

Conversation

@baptiste-marchand

@baptiste-marchand baptiste-marchand commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Align perps activity items with perps activity UI, showing order amount instead of PnL and increasing displayed decimals
  • Update referral code text in onboarding flow

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RWDS-600
Fixes: https://consensyssoftware.atlassian.net/browse/RWDS-607

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Very small screen (iPhone SE 3rd gen):

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Perps activity details now show asset amounts (up to 5 decimals) instead of PnL, and referral bonus copy is updated.

  • Rewards utils:
    • Perps details: CLOSE_POSITION/TAKE_PROFIT/STOP_LOSS now display <amount> <symbol> instead of PnL; OPEN_POSITION unchanged.
    • Precision: Increase formatted amount precision from 3 to 5 decimals by updating formatNumber and its usage in eventDetailsUtils.
  • Tests:
    • Update expectations to reflect amount-based details and 5-decimal rounding rules.
  • Localization:
    • Update en step4_referral_bonus_description copy; remove this key from other locales.

Written by Cursor Bugbot for commit 52903c9. This will update automatically on new commits. Configure here.

@baptiste-marchand baptiste-marchand requested a review from a team as a code owner October 13, 2025 11:11
@baptiste-marchand baptiste-marchand added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-rewards Rewards team labels Oct 13, 2025
@github-actions

github-actions Bot commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-wallet-standard Team responsible of the MetaMask Wallet Standard implementation label Oct 13, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@baptiste-marchand baptiste-marchand removed the team-wallet-standard Team responsible of the MetaMask Wallet Standard implementation label Oct 13, 2025
@VGR-GIT VGR-GIT added the regression-RC-7.57.0 Regression bug that was found in release candidate (RC) for release 7.57.0 label Oct 13, 2025
@baptiste-marchand baptiste-marchand linked an issue Oct 13, 2025 that may be closed by this pull request
Align perps activity items in Rewards with Perps activity UI #21103
Closed
9 tasks
cursor[bot]
cursor Bot reviewed Oct 13, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Referral Bonus Localization Inconsistency

The step4_title_referral_bonus and step4_referral_bonus_description localization keys are removed from non-English locales, but updated in English. This inconsistency causes missing referral bonus translations for non-English users.

locales/languages/hi.json#L5939-L5942

metamask-mobile/locales/languages/hi.json

Lines 5939 to 5942 in 429f629

"step3_description": "Each season brings new perks. Join in, compete, and claim what you can before time runs out.",
"step4_title": "You'll earn 250 points when you sign up!",
"step4_title_referral_validating": "Validating referral code...",
"step4_referral_input_placeholder": "Referral code (optional)",

locales/languages/el.json#L5939-L5942

metamask-mobile/locales/languages/el.json

Lines 5939 to 5942 in 429f629

"step3_description": "Each season brings new perks. Join in, compete, and claim what you can before time runs out.",
"step4_title": "You'll earn 250 points when you sign up!",
"step4_title_referral_validating": "Validating referral code...",
"step4_referral_input_placeholder": "Referral code (optional)",

locales/languages/es.json#L5939-L5942

metamask-mobile/locales/languages/es.json

Lines 5939 to 5942 in 429f629

"step3_description": "Each season brings new perks. Join in, compete, and claim what you can before time runs out.",
"step4_title": "You'll earn 250 points when you sign up!",
"step4_title_referral_validating": "Validating referral code...",
"step4_referral_input_placeholder": "Referral code (optional)",

locales/languages/tr.json#L5939-L5942

metamask-mobile/locales/languages/tr.json

Lines 5939 to 5942 in 429f629

"step3_description": "Each season brings new perks. Join in, compete, and claim what you can before time runs out.",
"step4_title": "You'll earn 250 points when you sign up!",
"step4_title_referral_validating": "Validating referral code...",
"step4_referral_input_placeholder": "Referral code (optional)",

Fix in Cursor Fix in Web

@sonarqubecloud

sonarqubecloud Bot commented Oct 13, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@baptiste-marchand baptiste-marchand linked an issue Oct 13, 2025 that may be closed by this pull request
Update referral code text in onboarding flow #21106
Closed
9 tasks
@baptiste-marchand baptiste-marchand added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit 5058ba5 Oct 13, 2025
109 of 113 checks passed
@baptiste-marchand baptiste-marchand deleted the RWDS-607-align-perps-activity-items-with-perps-activity-ui branch October 13, 2025 16:08
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2025
@metamaskbot metamaskbot added the release-7.58.0 Issue or pull request that will be included in release 7.58.0 label Oct 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@jbblanc jbblanc jbblanc approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed regression-RC-7.57.0 Regression bug that was found in release candidate (RC) for release 7.57.0 release-7.58.0 Issue or pull request that will be included in release 7.58.0 size-S team-rewards Rewards team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update referral code text in onboarding flow Align perps activity items in Rewards with Perps activity UI

5 participants

@baptiste-marchand @jbblanc @VGR-GIT @metamaskbot @Montoya