fix: multichain account network permissions switch cp-7.57.0#21043
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
gantunesr
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR fixes following problem:
When a user changes network permissions for a connected dapp (by going to Permissions tab → "Use your enabled networks" → selecting different networks → Update), the dapp's provider doesn't get notified of the network change. Transactions continue to execute on the initial network instead of the newly permitted network.
Changelog
CHANGELOG entry: Fixed a bug preventing network switch when dapp network permissions changes
Related issues
Fixes: #20722
Manual testing steps
Screenshots/Recordings
dapp-network-permissions.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Switches the active EVM network for a dapp when network permissions change and triggers a provider update notification.
MultichainAccountPermissions.tsx):handleNetworksSelectedto switch the dapp's active EVM network when the current permitted network is removed and another EVM chain is selected.isPerDappSelectedNetworkEnabled,useNetworkInfo, andselectEvmChainIdto resolve current chain and per-dapp context.networkConfigurations, extractsnetworkClientId, callsSelectedNetworkController.setNetworkClientIdForDomain, and triggersSelectedNetworkController.updateto notify the dapp.parseChainId,KnownCaipNamespace,hasProperty) and types (NetworkConfiguration).MultichainAccountPermissions.test.tsx):Written by Cursor Bugbot for commit ab6d187. This will update automatically on new commits. Configure here.