fix: Adding missing metrics property is_smart_transaction for smart transactions#21027
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
approved these changes
Oct 10, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Adding missing metrics property
is_smart_transactionfor smart transactionsChangelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5766
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds
is_smart_transactionflag to smart transaction metrics and returns it whenstatusMetadatais missing; updates tests accordingly.app/util/smart-transactions/index.tsgetSmartTransactionMetricsProperties: now returns{ is_smart_transaction: true }when a smart transaction exists withoutstatusMetadata, and includesis_smart_transactionin the returned metrics object.app/util/smart-transactions/index.test.ts: update expectations to includeis_smart_transactionin relevant cases; adjust test to expect{ is_smart_transaction: true }whenstatusMetadatais undefined.app/core/Engine/controllers/transaction-controller/event-handlers/metrics.test.ts: includeis_smart_transactionin mocked properties and assertions for finalized transaction metrics.Written by Cursor Bugbot for commit 26f2d9c. This will update automatically on new commits. Configure here.