Skip to content

chore: Bump Snaps packages#20684

Merged
FrederikBolding merged 2 commits into
mainfrom
fb/snaps-bump-v126
Oct 3, 2025
Merged

chore: Bump Snaps packages#20684
FrederikBolding merged 2 commits into
mainfrom
fb/snaps-bump-v126

Conversation

@FrederikBolding

@FrederikBolding FrederikBolding commented Oct 2, 2025 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Member

Description

This bumps Snaps packages to the latest version. Notable changes include:

  • Reduce JSON validation during state updates
  • Move JSON-RPC request inspection outside of the executor
  • Simplify JSON-RPC failure validation
  • Properly roll back initialConnections
  • Display a warning instead of an error when Snaps fail to terminate

Generally this should help with ongoing performance regressions when using Solana.

Note

Upgrades Snaps-related packages and removes featureFlags.useCaip25Permission from Snap controller initialization and tests.

  • Engine (Snaps controller init):
    • Remove featureFlags.useCaip25Permission from snap-controller-init.ts and update test expectations in snap-controller-init.test.ts.
  • Dependencies:
    • Upgrade @metamask/snaps-controllers to ^15.0.0, snaps-execution-environments to ^10.2.2, snaps-rpc-methods to ^13.5.2, snaps-sdk to ^10.0.0, and snaps-utils to ^11.6.0 in package.json.
    • Add resolution for @metamask/snaps-sdk@^10.0.0; refresh yarn.lock with related updates (e.g., @metamask/providers@^22.1.1, @metamask/slip44@^4.3.0).

Written by Cursor Bugbot for commit 48f4bd6. This will update automatically on new commits. Configure here.

@github-actions github-actions Bot added the size-S label Oct 2, 2025
@socket-security

socket-security Bot commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​slip44@​4.2.0 ⏵ 4.3.0100 +110099 +187 +3100
Updatednpm/​@​metamask/​providers@​22.1.0 ⏵ 22.1.199 +110093 +192 +2100
Addednpm/​@​metamask/​snaps-controllers@​15.0.0100100100100100
Addednpm/​@​metamask/​snaps-sdk@​10.0.0100100100100100
Updatednpm/​@​metamask/​snaps-rpc-methods@​13.5.0 ⏵ 13.5.2100 +2100100 +27100 +4100 +50
Updatednpm/​@​metamask/​snaps-execution-environments@​10.2.1 ⏵ 10.2.2100 +2100100 +24100 +10100 +20
Updatednpm/​@​metamask/​snaps-utils@​11.5.0 ⏵ 11.6.0100 +3100100 +25100 +9100

View full report

@danroc

danroc commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

LGTM. Are you planning to push other changes before marking this PR as ready for review?

@FrederikBolding

FrederikBolding commented Oct 3, 2025

Copy link
Copy Markdown
Member Author

LGTM. Are you planning to push other changes before marking this PR as ready for review?

Was hoping to run Snaps E2E on this. Which was broken by breaking changes to the E2E framework. Hopefully later today.

@FrederikBolding FrederikBolding added the team-core-platform Core Platform team label Oct 3, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 3, 2025
@github-actions

github-actions Bot commented Oct 3, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ flask_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 48f4bd6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/52a00a81-a9b5-4a9c-b228-feee1af8bda5

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another flask_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@FrederikBolding FrederikBolding marked this pull request as ready for review October 3, 2025 13:48
@FrederikBolding FrederikBolding requested a review from a team as a code owner October 3, 2025 13:48
@sonarqubecloud

sonarqubecloud Bot commented Oct 3, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cryptodev-2s
cryptodev-2s approved these changes Oct 3, 2025
View reviewed changes

@cryptodev-2s cryptodev-2s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 3, 2025
Merged via the queue into main with commit 8ee3984 Oct 3, 2025
115 of 118 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v126 branch October 3, 2025 14:40
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 3, 2025
@metamaskbot metamaskbot added the release-7.58.0 Issue or pull request that will be included in release 7.58.0 label Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.58.0 Issue or pull request that will be included in release 7.58.0 size-S team-core-platform Core Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FrederikBolding @danroc @cryptodev-2s @metamaskbot