Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19167 +/- ##
==========================================
- Coverage 76.03% 76.03% -0.01%
==========================================
Files 3201 3201
Lines 75664 75708 +44
Branches 13441 13440 -1
==========================================
+ Hits 57532 57565 +33
- Misses 14409 14421 +12
+ Partials 3723 3722 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
In app/core/RPCMethods/networkChecker.util.ts, What are your thoughts on modifying There are other places that make a request to |
That's a good idea, that should work, I'll try this. |
Actually I just tried but Let me know what you think |
|
sorry to clarify, not only does something like this? |
|
adonesky1
left a comment
There was a problem hiding this comment.
Ideally I'd love for us to find a more durable pattern than a whitelist but this looks fine for now. Do we need to do this on extension too? And if so should we have a consolidated list shared across both clients?







Description
Currently there are warnings when adding the HyperEVM network on the name/symbol because it uses the chain ID 999 which is the same as WAN CHAIN, this PR is intented to deal with those warnings as an exception specific to HyperEVM to remove those warnings.
Changelog
CHANGELOG entry: Removed warnings when adding HyperEVM as a custom network
Related issues
NA
Manual testing steps
Screenshots/Recordings
NA
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist