Skip to content

chore: implement iOS runners for e2e tests#19091

Merged
makemesteaks merged 44 commits into
mainfrom
cirrus-runners
Sep 5, 2025
Merged

chore: implement iOS runners for e2e tests#19091
makemesteaks merged 44 commits into
mainfrom
cirrus-runners

Conversation

@makemesteaks

@makemesteaks makemesteaks commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Description

🎯 Overview

This PR implements comprehensive improvements to our CI/CD infrastructure by migrating to Cirrus Labs runners for iOS testing and implementing various E2E testing optimizations and fixes.

🏗️ Infrastructure Changes

Runner Configuration

  • Cirrus Labs Integration: Migrated iOS E2E tests to use ghcr.io/cirruslabs/macos-runner:sequoia runners
  • Runner Size Optimization: Implemented XL build configurations for improved performance
  • Multi-platform Support: Enhanced workflow configurations for both iOS and Android platforms

Build System Improvements

  • iOS Build Speed Optimization: Reduced build times through optimized configurations and caching
  • Detox Framework Caching: Implemented proper cache management for iOS testing framework
  • Environment Variable Management: Streamlined E2E test environment setup with proper variable passing

🧪 E2E Testing Enhancements

Test Reliability & Stability

  • Flake Reduction: Fixed multiple E2E test flakes across iOS and Android platforms
  • Synchronization Improvements: Enhanced wallet creation and token list loading stability
  • iPhone Model Updates: Updated Detox configuration to use iPhone 16 Pro with iOS 18.6
  • Timeout Handling: Improved test timeout management and retry mechanisms

Test Infrastructure

  • Matrix Testing: Implemented test splitting and parallelization for improved efficiency
  • Artifact Management: Enhanced build artifact handling and reuse capabilities
  • Debug Utilities: Added sleep utility functions and text input delays for better test stability

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label Sep 2, 2025
@codecov-commenter

codecov-commenter commented Sep 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.92%. Comparing base (eccd787) to head (209311c).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19091      +/-   ##
==========================================
+ Coverage   75.82%   75.92%   +0.10%     
==========================================
  Files        3180     3188       +8     
  Lines       74654    74903     +249     
  Branches    13152    13230      +78     
==========================================
+ Hits        56605    56871     +266     
+ Misses      14377    14339      -38     
- Partials     3672     3693      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added size-S and removed size-XS labels Sep 3, 2025
@github-actions github-actions Bot added size-M and removed size-S labels Sep 3, 2025
@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@makemesteaks makemesteaks marked this pull request as ready for review September 4, 2025 14:23
@makemesteaks makemesteaks requested a review from a team as a code owner September 4, 2025 14:23
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cmd-ob
cmd-ob previously approved these changes Sep 5, 2025
@cmd-ob cmd-ob added No E2E Smoke Needed QA Passed QA testing has been completed and passed labels Sep 5, 2025
@makemesteaks makemesteaks changed the title test cirrus runners ios chore: implement iOS runners for e2e tests Sep 5, 2025
@makemesteaks makemesteaks added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Sep 5, 2025
@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2025

Copy link
Copy Markdown

@makemesteaks makemesteaks added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 53cab83 Sep 5, 2025
108 of 133 checks passed
@makemesteaks makemesteaks deleted the cirrus-runners branch September 5, 2025 16:28
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 5, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed QA Passed QA testing has been completed and passed release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-M team-dev-ops DevOps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants